Bug 72265 - Web Inspector: add 'Show function definition' context menu item for function values
Summary: Web Inspector: add 'Show function definition' context menu item for function ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 06:19 PST by Yury Semikhatsky
Modified: 2011-11-14 07:56 PST (History)
10 users (show)

See Also:


Attachments
Patch (6.33 KB, patch)
2011-11-14 06:21 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (6.47 KB, patch)
2011-11-14 06:24 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (6.47 KB, patch)
2011-11-14 06:26 PST, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-11-14 06:19:31 PST
Web Inspector: add 'Show function definition' context menu item for function values
Comment 1 Yury Semikhatsky 2011-11-14 06:21:35 PST
Created attachment 114931 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-14 06:24:54 PST
Created attachment 114933 [details]
Patch
Comment 3 Yury Semikhatsky 2011-11-14 06:26:11 PST
Created attachment 114934 [details]
Patch
Comment 4 Pavel Feldman 2011-11-14 06:37:53 PST
Comment on attachment 114934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114934&action=review

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:265
> +            WebInspector.showPanelForAnchorNavigation(WebInspector.panels.scripts);

Call this from the one below.

> Source/WebCore/inspector/front-end/inspector.js:840
>      if (this.drawer)

You don't need this.
Comment 5 Yury Semikhatsky 2011-11-14 06:44:16 PST
(In reply to comment #4)
> (From update of attachment 114934 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114934&action=review
> 
> > Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:265
> > +            WebInspector.showPanelForAnchorNavigation(WebInspector.panels.scripts);
> 
> Call this from the one below.
> 
Done.

> > Source/WebCore/inspector/front-end/inspector.js:840
> >      if (this.drawer)
> 
> You don't need this.
Done.
Comment 6 Yury Semikhatsky 2011-11-14 07:56:27 PST
Committed r100143: <http://trac.webkit.org/changeset/100143>