Bug 72262 - [Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
Summary: [Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pierre Rossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 05:41 PST by Pierre Rossi
Modified: 2011-11-15 05:43 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2011-11-14 05:44 PST, Pierre Rossi 		no flags Details | Formatted Diff | Diff
Patch (7.28 KB, patch)
2011-11-14 06:23 PST, Pierre Rossi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Rossi 2011-11-14 05:41:33 PST 
[Qt] Clean up the remaining duplicate code after the RenderThemeQt refactoring.
Comment 1 Pierre Rossi 2011-11-14 05:44:57 PST 
Created attachment 114924 [details]
Patch
Comment 2 Pierre Rossi 2011-11-14 06:23:19 PST 
Created attachment 114932 [details]
Patch
Comment 3 WebKit Review Bot 2011-11-15 04:16:29 PST 
Comment on attachment 114932 [details]
Patch

Rejecting attachment 114932 [details] from commit-queue.

pierre.rossi@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 4 WebKit Review Bot 2011-11-15 05:43:51 PST 
Comment on attachment 114932 [details]
Patch

Clearing flags on attachment: 114932

Committed r100270: <http://trac.webkit.org/changeset/100270>
Comment 5 WebKit Review Bot 2011-11-15 05:43:55 PST 
All reviewed patches have been landed.  Closing bug.