Bug 72259 - [Qt][WK2] Cleanup QML tests.
Summary: [Qt][WK2] Cleanup QML tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-11-14 05:23 PST by Alexis Menard (darktears)
Modified: 2011-11-14 09:16 PST (History)
6 users (show)

See Also:


Attachments
Patch (49.84 KB, patch)
2011-11-14 05:26 PST, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-11-14 05:23:16 PST
[Qt][WK2] Cleanup QML tests.
Comment 1 Alexis Menard (darktears) 2011-11-14 05:26:04 PST
Created attachment 114922 [details]
Patch
Comment 2 Alexis Menard (darktears) 2011-11-14 05:27:16 PST
@Tor-Arne: This will not trigger a rebuild as QML tests are dynamically loaded. I guess it should work out of the box but let's see.
Comment 3 Tor Arne Vestbø 2011-11-14 05:45:07 PST
Should work yes. If not, there are qmake-tricks we can pull to make the test-target-executable depend on all the QML files as well, if that's needed for some reason.
Comment 4 Simon Hausmann 2011-11-14 07:51:17 PST
Comment on attachment 114922 [details]
Patch

rs=me
Comment 5 WebKit Review Bot 2011-11-14 09:16:43 PST
Comment on attachment 114922 [details]
Patch

Clearing flags on attachment: 114922

Committed r100155: <http://trac.webkit.org/changeset/100155>
Comment 6 WebKit Review Bot 2011-11-14 09:16:48 PST
All reviewed patches have been landed.  Closing bug.