Bug 72258 – [GTK] Implement download support in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

It's currently unimplemented in WebProcess.

[Carlos Garcia Campos]

Created attachment 114921 [details]
Patch

[Martin Robinson]

Comment on attachment 114921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114921&action=review

Looks good, but I'm not sure the changes in Source/WebKit/gtk/webkit/webkitdownload.cpp are necessary...

> Source/WebKit/gtk/webkit/webkitdownload.cpp:476
> +        webkitDownloadEmitError(download, downloadDestinationError(core(priv->networkResponse), error->message));

It It seems like this code is just using the ResourceError to carry the message and the error code to webkitDownloadEmitError. Why not just pass the error code and the message directly?

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 114921 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114921&action=review
> 
> Looks good, but I'm not sure the changes in Source/WebKit/gtk/webkit/webkitdownload.cpp are necessary...

No, they are not necessary, but since I moved the download errors to WebCore, I think wk1 should use them, so that we avoid having the same translatable strings in two different places.

> > Source/WebKit/gtk/webkit/webkitdownload.cpp:476
> > +        webkitDownloadEmitError(download, downloadDestinationError(core(priv->networkResponse), error->message));
> 
> It It seems like this code is just using the ResourceError to carry the message and the error code to webkitDownloadEmitError. Why not just pass the error code and the message directly?

In this case it would be possible, because DestinationError is built with the message, but for other errors we need the ResourceError to get the message from it, for example:

webkitDownloadEmitError(download, downloadCancelledByUserError(core(priv->networkResponse)));

[Carlos Garcia Campos]

Committed r100284: <http://trac.webkit.org/changeset/100284>