Add SCMDetector object to make scm detection mockable
Created attachment 114893 [details] Patch
Committed r100104: <http://trac.webkit.org/changeset/100104>
Comment on attachment 114893 [details] Patch Clearing the commit-queue flag since the patch for this bug was landed as per comment 2.
This patch appears to have broken windows builds. Rolling back shortly. Example log: https://bugs.webkit.org/show_bug.cgi?id=72247 Philn informs me I'll also need to roll back r100116, so I assume that should be part of the patch when it rolls forward again.
Reverted r100104 for reason: broke windows builds Committed r100118: <http://trac.webkit.org/changeset/100118>
> Example log: > https://bugs.webkit.org/show_bug.cgi?id=72247 Copy/paste fail. Log is: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/8621/steps/webkit_tests/logs/stdio This showed up on XP, Vista and Win 7.
Yeah, that's fallout from adding _initialize_scm() before _engage_awesome_windows_hacks are called. Very easy to fix. Will re-land shortly.
We're now engaging windows hacks harder: http://trac.webkit.org/changeset/100421 I'll roll this back in tomorrow when I'm more awake.
Committed r100558: <http://trac.webkit.org/changeset/100558>
Seems like this patch has broken tests for me. 'svn info' is locale dependent, so it always returns "ScriptError: svn info did not contain a Repository UUID." Obvious fix would be running svn info in clean environment. I can prepare a patch for this.