Bug 72235 – [SOUP][WK2] Add initial WebCookieManagerSoup.cpp for webkit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Jongseok Yang]

The implementation for WebCookieManager::platformSetHTTPCookieAcceptPolicy and WebCookieManager::platformGetHTTPCookieAcceptPolicy is required to support Webkit2 API for cookie manager.
WebCookieManagerSoup.cpp includes these functions.
If soup network back-end is used, the file should be used.

[Jongseok Yang]

Created attachment 114873 [details]
patch for WebCookieManagerSoup.cpp

[Gustavo Noronha (kov)]

Comment on attachment 114873 [details]
patch for WebCookieManagerSoup.cpp

This patch looks good to me, but it isn't wired into any of the build systems, that's why I r- it. You should wire it into the gtk (unconditionally) and efl (conditioned on it using soup) build systems at least, I believe.

[Jongseok Yang]

Created attachment 114912 [details]
patch v2

The patch updates "Source/WebKit2/GNUmakefile.am" to build "WebCookieManagerSoup.cpp".
And it removes "WebCookieManagerGtk.cpp" because gtk port uses soup network backend.

[Jongseok Yang]

Created attachment 114915 [details]
patch v2 : re-upload

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 114873 [details])
> This patch looks good to me, but it isn't wired into any of the build systems, that's why I r- it. You should wire it into the gtk (unconditionally) and efl (conditioned on it using soup) build systems at least, I believe.

AFAIK, efl port of WebKit2 will use soup or curl as well. So, I think WebCookieManagerEfl.cpp is able to be removed. How do you think remove WebCookieManagerEfl.cpp together?

[Jongseok Yang]

(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 114873 [details] [details])
> > This patch looks good to me, but it isn't wired into any of the build systems, that's why I r- it. You should wire it into the gtk (unconditionally) and efl (conditioned on it using soup) build systems at least, I believe.
> 
> AFAIK, efl port of WebKit2 will use soup or curl as well. So, I think WebCookieManagerEfl.cpp is able to be removed. How do you think remove WebCookieManagerEfl.cpp together?

I agree with you. I'll remove WebCookieManagerEfl.cpp.
And the patch for CMakeListsEfl.txt should include the change of my patch.(https://bugs.webkit.org/show_bug.cgi?id=61999)

[Tomasz Morawski]

> And the patch for CMakeListsEfl.txt should include the change of my patch.(https://bugs.webkit.org/show_bug.cgi?id=61999)
Not only changed by finally merged to avoid similar issues in future.

[Jongseok Yang]

Created attachment 115107 [details]
patch v3

the patch removes WebCookieManagerGtk.cpp, WebCookieManagerEfl.cpp

[Jongseok Yang]

Created attachment 115111 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 115111 [details]
Patch

OK!

[WebKit Review Bot]

Comment on attachment 115111 [details]
Patch

Clearing flags on attachment: 115111

Committed r100362: <http://trac.webkit.org/changeset/100362>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.