WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72196
Remove the CSS3_FLEXBOX compile time flag and enable on all ports
https://bugs.webkit.org/show_bug.cgi?id=72196
Summary
Remove the CSS3_FLEXBOX compile time flag and enable on all ports
Tony Chang
Reported
2011-11-11 16:35:21 PST
Remove the CSS3_FLEXBOX compile time flag and enable on all ports
Attachments
Patch
(61.48 KB, patch)
2011-11-11 16:42 PST
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch
(63.01 KB, patch)
2011-11-14 09:31 PST
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch
(62.93 KB, patch)
2011-11-14 10:57 PST
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Patch for landing
(62.58 KB, patch)
2011-11-14 13:58 PST
,
Tony Chang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2011-11-11 16:42:53 PST
Created
attachment 114800
[details]
Patch
Tony Chang
Comment 2
2011-11-14 09:31:22 PST
Created
attachment 114965
[details]
Patch
Tony Chang
Comment 3
2011-11-14 10:57:51 PST
Created
attachment 114984
[details]
Patch
Ojan Vafai
Comment 4
2011-11-14 12:14:17 PST
Comment on
attachment 114984
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=114984&action=review
> Source/WebCore/css/CSSValueKeywords.in:329 > -webkit-box > -webkit-inline-box > --wap-marquee > -webkit-flexbox > -webkit-inline-flexbox > +-wap-marquee
I'm not convinced this is correct. I expect this is dead code, but this should be a separate patch.
Tony Chang
Comment 5
2011-11-14 13:58:26 PST
Created
attachment 115028
[details]
Patch for landing
WebKit Review Bot
Comment 6
2011-11-14 14:52:08 PST
Comment on
attachment 115028
[details]
Patch for landing Clearing flags on attachment: 115028 Committed
r100198
: <
http://trac.webkit.org/changeset/100198
>
WebKit Review Bot
Comment 7
2011-11-14 14:52:13 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug