Bug 72196 - Remove the CSS3_FLEXBOX compile time flag and enable on all ports
Summary: Remove the CSS3_FLEXBOX compile time flag and enable on all ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency treegraph
 
Reported: 2011-11-11 16:35 PST by Tony Chang
Modified: 2011-11-14 14:52 PST (History)
4 users (show)

See Also:


Attachments
Patch (61.48 KB, patch)
2011-11-11 16:42 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (63.01 KB, patch)
2011-11-14 09:31 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (62.93 KB, patch)
2011-11-14 10:57 PST, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (62.58 KB, patch)
2011-11-14 13:58 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-11-11 16:35:21 PST
Remove the CSS3_FLEXBOX compile time flag and enable on all ports
Comment 1 Tony Chang 2011-11-11 16:42:53 PST
Created attachment 114800 [details]
Patch
Comment 2 Tony Chang 2011-11-14 09:31:22 PST
Created attachment 114965 [details]
Patch
Comment 3 Tony Chang 2011-11-14 10:57:51 PST
Created attachment 114984 [details]
Patch
Comment 4 Ojan Vafai 2011-11-14 12:14:17 PST
Comment on attachment 114984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114984&action=review

> Source/WebCore/css/CSSValueKeywords.in:329
>  -webkit-box
>  -webkit-inline-box
> --wap-marquee
>  -webkit-flexbox
>  -webkit-inline-flexbox
> +-wap-marquee

I'm not convinced this is correct. I expect this is dead code, but this should be a separate patch.
Comment 5 Tony Chang 2011-11-14 13:58:26 PST
Created attachment 115028 [details]
Patch for landing
Comment 6 WebKit Review Bot 2011-11-14 14:52:08 PST
Comment on attachment 115028 [details]
Patch for landing

Clearing flags on attachment: 115028

Committed r100198: <http://trac.webkit.org/changeset/100198>
Comment 7 WebKit Review Bot 2011-11-14 14:52:13 PST
All reviewed patches have been landed.  Closing bug.