Bug 72187 – Update iOS port's configuration setting, particularly in Platform.h

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

These settings are not up to date.

[Gavin Barraclough]

Created attachment 114776 [details]
Fix

[WebKit Review Bot]

Attachment 114776 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/FastMalloc.cpp:1952:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Kilzer (:ddkilzer)]

Comment on attachment 114776 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=114776&action=review

r=me

>> Source/JavaScriptCore/wtf/FastMalloc.cpp:1952
>> +  static const size_t kDefaultReleaseDelay = 64;
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Please fix this style issue.

> Source/JavaScriptCore/wtf/FastMalloc.cpp:1977
> +#if PLATFORM(IOS)
> +      scavenge_counter_ = std::max<size_t>(16UL, std::min<size_t>(kDefaultReleaseDelay, kDefaultReleaseDelay - (free_pages_ / kDefaultReleaseDelay)));
> +#else
>        scavenge_counter_ = std::max<size_t>(64UL, std::min<size_t>(kDefaultReleaseDelay, kDefaultReleaseDelay - (free_pages_ / kDefaultReleaseDelay)));
> +#endif

Nit: We could pull out 16UL and 64UL into constants in a future commit so we only have to use macros around the value.

[Gavin Barraclough]

> >> Source/JavaScriptCore/wtf/FastMalloc.cpp:1952
> >> +  static const size_t kDefaultReleaseDelay = 64;
> > 
> > Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> 
> Please fix this style issue.

Actually, I don't think we want to do so in this case. This entire file is in 2-space indenting (to make it easier to merge changes, this code originally comes from an external source), if we're going to change this I think we should change the whole file at once.

> Nit: We could pull out 16UL and 64UL into constants in a future commit so we only have to use macros around the value.

*nod, you're right, that would be better.

[Gavin Barraclough]

Fixed in r100037