Remove expected crashes for skia-gpu canvas from test expectations
Created attachment 114771 [details] Patch
This has been fixed for a while.
Comment on attachment 114771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114771&action=review > LayoutTests/platform/chromium/test_expectations.txt:-3730 > -BUGWK70013 WIN GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT CRASH This test is still failing TEXT on Windows, I believe (thanks to my recent patch). Could you change line 3869 from MAC LINUX GPU to just GPU to accomodate WIN as well? Thanks.
Created attachment 114925 [details] Patch
(In reply to comment #3) > (From update of attachment 114771 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114771&action=review > > > LayoutTests/platform/chromium/test_expectations.txt:-3730 > > -BUGWK70013 WIN GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT CRASH > > This test is still failing TEXT on Windows, I believe (thanks to my recent patch). Could you change line 3869 from MAC LINUX GPU to just GPU to accomodate WIN as well? Thanks. Sure, done. For some reason webkit-patch printed "Path does not exist." about every entry in test_expectations.txt. I don't think it has anything to do with my change though.
Attachment 114925 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Last 3072 characters of output: tml [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3840: Path does not exist. svg/zoom/page/relative-sized-document-scrollbars.svg [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3842: Path does not exist. storage/indexeddb/key-type-array.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3844: Path does not exist. storage/indexeddb/factory-deletedatabase-interactions.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3846: Path does not exist. fast/js/array-functions-non-arrays.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3847: Path does not exist. fast/js/eval-cross-window.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3848: Path does not exist. fast/js/regexp-caching.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3849: Path does not exist. fast/js/toString-overrides.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3850: Path does not exist. fast/js/toString-recursion.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3851: Path does not exist. http/tests/security/xss-eval.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3853: Path does not exist. fast/dom/javascript-url-exception-isolation.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3854: Path does not exist. fast/borders/inline-mask-overlay-image-outset-vertical-rl.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3856: Path does not exist. fast/dom/rtl-scroll-to-leftmost-and-resize.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3858: Path does not exist. accessibility/adjacent-continuations-cause-assertion-failure.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3860: Path does not exist. inspector/debugger/script-formatter.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3863: Path does not exist. fast/js/mozilla/strict/15.4.5.1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3865: Path does not exist. fast/canvas/canvas-transforms-fillRect-shadow.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3867: Path does not exist. media/track/tracklist-is-reachable.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3869: Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3870: Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3872: Path does not exist. http/tests/security/cross-frame-access-custom.html [test/expectations] [2] Total errors found: 2122 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 114925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114925&action=review Thanks for the cleanup. r=me >> LayoutTests/platform/chromium/test_expectations.txt:3865 >> +BUG_SENORBLANCO GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = TEXT > > Path does not exist. fast/canvas/canvas-transforms-fillRect-shadow.html [test/expectations] [2] Not sure what's going on with the style bot; those paths look fine to me.
Comment on attachment 114925 [details] Patch Clearing flags on attachment: 114925 Committed r100148: <http://trac.webkit.org/changeset/100148>
All reviewed patches have been landed. Closing bug.