RESOLVED FIXED 72175
Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X 
https://bugs.webkit.org/show_bug.cgi?id=72175
Summary Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
David Kilzer (:ddkilzer)
Reported 2011-11-11 13:37:52 PST
Created attachment 114763 [details] Patch <http://webkit.org/b/NNNNN> Reviewed by NOBODY (OOPS!). * wtf/Platform.h: Move the definition of the BUILDING_ON_* and TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined so that they're only defined on Mac OS X builds. Also include Availability.h, which is needed on iOS builds. --- 2 files changed, 25 insertions(+), 13 deletions(-)
Attachments
Patch (2.77 KB, patch)
2011-11-11 13:37 PST, David Kilzer (:ddkilzer) 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-11-11 13:40:54 PST
Attachment 114763 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 2 2011-11-11 13:51:27 PST
Comment on attachment 114763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114763&action=review > Source/JavaScriptCore/wtf/Platform.h:327 > + || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) \ Might as well fix the end of line spacing on this line. Either have the "\"s line up (like I think is normal for macros) or just one space after the line.
David Kilzer (:ddkilzer)
Comment 3 2011-11-11 14:57:45 PST
Committed r100031: <http://trac.webkit.org/changeset/100031>
David Kilzer (:ddkilzer)
Comment 4 2011-11-11 16:21:05 PST
<rdar://problem/7876444>
Note You need to log in before you can comment on or make changes to this bug.