Bug 72175 - Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
Summary: Only define BUILDING_ON_* and TARGETING_* macros when building for Mac OS X
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on:
Reported: 2011-11-11 13:37 PST by David Kilzer (:ddkilzer)
Modified: 2011-11-11 16:21 PST (History)
3 users (show)

See Also:

Patch (2.77 KB, patch)
2011-11-11 13:37 PST, David Kilzer (:ddkilzer)
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2011-11-11 13:37:52 PST
Created attachment 114763 [details]


Reviewed by NOBODY (OOPS!).

* wtf/Platform.h: Move the definition of the BUILDING_ON_* and
TARGETING_* macros to where the WTF_OS_MAC_OS_X macro is defined
so that they're only defined on Mac OS X builds.  Also include
Availability.h, which is needed on iOS builds.
 2 files changed, 25 insertions(+), 13 deletions(-)
Comment 1 WebKit Review Bot 2011-11-11 13:40:54 PST
Attachment 114763 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Joseph Pecoraro 2011-11-11 13:51:27 PST
Comment on attachment 114763 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=114763&action=review

> Source/JavaScriptCore/wtf/Platform.h:327
> +    || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)                   \

Might as well fix the end of line spacing on this line. Either have the "\"s line up
(like I think is normal for macros) or just one space after the line.
Comment 3 David Kilzer (:ddkilzer) 2011-11-11 14:57:45 PST
Committed r100031: <http://trac.webkit.org/changeset/100031>
Comment 4 David Kilzer (:ddkilzer) 2011-11-11 16:21:05 PST