Bug 72156 – build-webkit: Accept --cmakeargs to pass additional arguments to CMake.

Bug 72156 - build-webkit: Accept --cmakeargs to pass additional arguments to CMake.


Summary:	build-webkit: Accept --cmakeargs to pass additional arguments to CMake.

Status:	RESOLVED FIXED

Product:	WebKit
Component:	New Bugs
Version:	528+ (Nightly build)
Platform:	Unspecified Unspecified

Importance:	P2 Normal
Assigned To:	Raphael Kubo da Costa (:rakuco)

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-11-11 11:05 PST by Raphael Kubo da Costa (:rakuco)
Modified:	2011-11-14 22:43 PST (History)

Attachments
Patch (3.73 KB, patch) 2011-11-11 11:08 PST, Raphael Kubo da Costa (:rakuco)	no flags	Review Patch \| Details \| Formatted Diff \| Diff
Add an example to the usage message (3.79 KB, patch) 2011-11-11 11:14 PST, Raphael Kubo da Costa (:rakuco)	dbates: review+ dbates: commit‑queue-	Review Patch \| Details \| Formatted Diff \| Diff
Hide Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Raphael Kubo da Costa (:rakuco) 2011-11-11 11:05:35 PST

build-webkit: Accept --cmakeargs to pass additional arguments to CMake.

------- Comment #1 From Raphael Kubo da Costa (:rakuco) 2011-11-11 11:08:27 PST -------

Created an attachment (id=114736) [details]
Patch

------- Comment #2 From Patrick R. Gansterer 2011-11-11 11:10:34 PST -------

(From update of attachment 114736 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=114736&action=review

> Tools/Scripts/build-webkit:395
> +  --cmakearg=<arguments>            Optional CMake flags

maybe you can add  (eg. --cmakearg="-DFOO=bar")  like for qmakearg here too?

------- Comment #3 From Raphael Kubo da Costa (:rakuco) 2011-11-11 11:14:09 PST -------

Created an attachment (id=114738) [details]
Add an example to the usage message

------- Comment #4 From Daniel Bates 2011-11-11 11:21:00 PST -------

(From update of attachment 114738 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review

> Tools/Scripts/build-webkit:62
> +my $cmakeArgs = "";

Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.

------- Comment #5 From Raphael Kubo da Costa (:rakuco) 2011-11-11 12:13:43 PST -------

(In reply to comment #4)
> (From update of attachment 114738 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review
> 
> > Tools/Scripts/build-webkit:62
> > +my $cmakeArgs = "";
> 
> Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.

Thanks. I don't speak Perl, so this was mostly copy'n'paste from other places in build-webkit-patch and webkitdirs.pm :)

I haven't had my commit bit activated yet, so could you cq+ it too?

------- Comment #6 From Daniel Bates 2011-11-14 22:39:03 PST -------

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 114738 [details] [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review
> > 
> > > Tools/Scripts/build-webkit:62
> > > +my $cmakeArgs = "";
> > 
> > Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.
> 
> Thanks. I don't speak Perl, so this was mostly copy'n'paste from other places in build-webkit-patch and webkitdirs.pm :)
> 
> I haven't had my commit bit activated yet, so could you cq+ it too?

Will remove explicit initialization of $cmakeArgs and land this patch by hand.

------- Comment #7 From Daniel Bates 2011-11-14 22:43:07 PST -------

Committed r100241: <http://trac.webkit.org/changeset/100241>