RESOLVED FIXED 72156
build-webkit: Accept --cmakeargs to pass additional arguments to CMake.
https://bugs.webkit.org/show_bug.cgi?id=72156
Summary build-webkit: Accept --cmakeargs to pass additional arguments to CMake.
Raphael Kubo da Costa (:rakuco)
Reported 2011-11-11 11:05:35 PST
build-webkit: Accept --cmakeargs to pass additional arguments to CMake.
Attachments
Patch (3.73 KB, patch)
2011-11-11 11:08 PST, Raphael Kubo da Costa (:rakuco)
no flags
Add an example to the usage message (3.79 KB, patch)
2011-11-11 11:14 PST, Raphael Kubo da Costa (:rakuco)
dbates: review+
dbates: commit-queue-
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-11-11 11:08:27 PST
Patrick R. Gansterer
Comment 2 2011-11-11 11:10:34 PST
Comment on attachment 114736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114736&action=review > Tools/Scripts/build-webkit:395 > + --cmakearg=<arguments> Optional CMake flags maybe you can add (eg. --cmakearg="-DFOO=bar") like for qmakearg here too?
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-11-11 11:14:09 PST
Created attachment 114738 [details] Add an example to the usage message
Daniel Bates
Comment 4 2011-11-11 11:21:00 PST
Comment on attachment 114738 [details] Add an example to the usage message View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review > Tools/Scripts/build-webkit:62 > +my $cmakeArgs = ""; Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-11-11 12:13:43 PST
(In reply to comment #4) > (From update of attachment 114738 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review > > > Tools/Scripts/build-webkit:62 > > +my $cmakeArgs = ""; > > Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch. Thanks. I don't speak Perl, so this was mostly copy'n'paste from other places in build-webkit-patch and webkitdirs.pm :) I haven't had my commit bit activated yet, so could you cq+ it too?
Daniel Bates
Comment 6 2011-11-14 22:39:03 PST
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 114738 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review > > > > > Tools/Scripts/build-webkit:62 > > > +my $cmakeArgs = ""; > > > > Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch. > > Thanks. I don't speak Perl, so this was mostly copy'n'paste from other places in build-webkit-patch and webkitdirs.pm :) > > I haven't had my commit bit activated yet, so could you cq+ it too? Will remove explicit initialization of $cmakeArgs and land this patch by hand.
Daniel Bates
Comment 7 2011-11-14 22:43:07 PST
Note You need to log in before you can comment on or make changes to this bug.