Bug 72156 – build-webkit: Accept --cmakeargs to pass additional arguments to CMake.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Raphael Kubo da Costa (:rakuco)]

build-webkit: Accept --cmakeargs to pass additional arguments to CMake.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 114736 [details]
Patch

[Patrick R. Gansterer]

Comment on attachment 114736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114736&action=review

> Tools/Scripts/build-webkit:395
> +  --cmakearg=<arguments>            Optional CMake flags

maybe you can add  (eg. --cmakearg="-DFOO=bar")  like for qmakearg here too?

[Raphael Kubo da Costa (:rakuco)]

Created attachment 114738 [details]
Add an example to the usage message

[Daniel Bates]

Comment on attachment 114738 [details]
Add an example to the usage message

View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review

> Tools/Scripts/build-webkit:62
> +my $cmakeArgs = "";

Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #4)
> (From update of attachment 114738 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review
> 
> > Tools/Scripts/build-webkit:62
> > +my $cmakeArgs = "";
> 
> Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.

Thanks. I don't speak Perl, so this was mostly copy'n'paste from other places in build-webkit-patch and webkitdirs.pm :)

I haven't had my commit bit activated yet, so could you cq+ it too?

[Daniel Bates]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 114738 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=114738&action=review
> > 
> > > Tools/Scripts/build-webkit:62
> > > +my $cmakeArgs = "";
> > 
> > Nit: It's unnecessary to explicitly initialize this variable. Notice, both the empty string and an undefined value evaluate to 0 (false) on line 1644 of this patch.
> 
> Thanks. I don't speak Perl, so this was mostly copy'n'paste from other places in build-webkit-patch and webkitdirs.pm :)
> 
> I haven't had my commit bit activated yet, so could you cq+ it too?

Will remove explicit initialization of $cmakeArgs and land this patch by hand.

[Daniel Bates]

Committed r100241: <http://trac.webkit.org/changeset/100241>