Created attachment 114728 [details] The second FO box is not visible. When declaring multiple foreignObject elements, only the first one gets rendered. I tracked this down to a parser problem where the SVG closing tags are not being case-adjusted (like the starting tags are). Thus, foreignObject closing tags are not detected and subsequent FO elements are inserted as children. Patch coming soon.
Created attachment 114732 [details] Patch
Comment on attachment 114732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114732&action=review > LayoutTests/svg/foreignObject/multiple-foreign-objects.html:7 > + <body style="dmargin: 0;"> What is dmargin? > LayoutTests/svg/foreignObject/multiple-foreign-objects.html:8 > + <div style="background: #00ff00; width: 100px; height: 100px;"> </div> Would prefer "background-color: green;" No need for
Created attachment 114790 [details] Patch
Comment on attachment 114732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114732&action=review Thanks, updated. >> LayoutTests/svg/foreignObject/multiple-foreign-objects.html:7 >> + <body style="dmargin: 0;"> > > What is dmargin? My fat finger with some copy/paste help :-) >> LayoutTests/svg/foreignObject/multiple-foreign-objects.html:8 >> + <div style="background: #00ff00; width: 100px; height: 100px;"> </div> > > Would prefer "background-color: green;" No need for Done.
Comment on attachment 114790 [details] Patch Attachment 114790 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10449711 New failing tests: html5lib/runner.html
Created attachment 114952 [details] Patch
Comment on attachment 114952 [details] Patch Clearing flags on attachment: 114952 Committed r100157: <http://trac.webkit.org/changeset/100157>
All reviewed patches have been landed. Closing bug.
This appears to have broken 5 tests: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r100157%20(34687)/results.html
Thanks for catching this - you're referring to the 5 failing foreignObject tests, right? I actually think this only broke the last one (introduced in this patch, needs rebaselining) - the other 4 were introduced in r100045 and probably have been failing since (looks like they also need rebaselining on Leopard). I'll get on it first thing tomorrow, but I'd also appreciate some advice on how to do a better job at catching these in the future.