RESOLVED FIXED 72151
Multiple foreign objects not rendered 
https://bugs.webkit.org/show_bug.cgi?id=72151
Summary Multiple foreign objects not rendered
Florin Malita
Reported 2011-11-11 10:41:42 PST
Created attachment 114728 [details] The second FO box is not visible. When declaring multiple foreignObject elements, only the first one gets rendered. I tracked this down to a parser problem where the SVG closing tags are not being case-adjusted (like the starting tags are). Thus, foreignObject closing tags are not detected and subsequent FO elements are inserted as children. Patch coming soon.
Attachments
The second FO box is not visible. (546 bytes, text/html)
2011-11-11 10:41 PST, Florin Malita 		no flags
Details
Patch (5.52 KB, patch)
2011-11-11 10:59 PST, Florin Malita 		no flags
DetailsFormatted DiffDiff
Patch (5.39 KB, patch)
2011-11-11 15:48 PST, Florin Malita 		no flags
DetailsFormatted DiffDiff
Patch (10.08 KB, patch)
2011-11-14 08:31 PST, Florin Malita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Florin Malita
Comment 1 2011-11-11 10:59:29 PST
Created attachment 114732 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-11-11 15:13:27 PST
Comment on attachment 114732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114732&action=review > LayoutTests/svg/foreignObject/multiple-foreign-objects.html:7 > + <body style="dmargin: 0;"> What is dmargin? > LayoutTests/svg/foreignObject/multiple-foreign-objects.html:8 > + <div style="background: #00ff00; width: 100px; height: 100px;">&nbsp;</div> Would prefer "background-color: green;" No need for &nbsp;
Florin Malita
Comment 3 2011-11-11 15:48:44 PST
Created attachment 114790 [details] Patch
Florin Malita
Comment 4 2011-11-11 16:03:58 PST
Comment on attachment 114732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114732&action=review Thanks, updated. >> LayoutTests/svg/foreignObject/multiple-foreign-objects.html:7 >> + <body style="dmargin: 0;"> > > What is dmargin? My fat finger with some copy/paste help :-) >> LayoutTests/svg/foreignObject/multiple-foreign-objects.html:8 >> + <div style="background: #00ff00; width: 100px; height: 100px;">&nbsp;</div> > > Would prefer "background-color: green;" No need for &nbsp; Done.
WebKit Review Bot
Comment 5 2011-11-11 23:19:48 PST
Comment on attachment 114790 [details] Patch Attachment 114790 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10449711 New failing tests: html5lib/runner.html
Florin Malita
Comment 6 2011-11-14 08:31:05 PST
Created attachment 114952 [details] Patch
WebKit Review Bot
Comment 7 2011-11-14 09:31:46 PST
Comment on attachment 114952 [details] Patch Clearing flags on attachment: 114952 Committed r100157: <http://trac.webkit.org/changeset/100157>
WebKit Review Bot
Comment 8 2011-11-14 09:31:51 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 9 2011-11-14 16:42:29 PST
This appears to have broken 5 tests: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r100157%20(34687)/results.html
Florin Malita
Comment 10 2011-11-14 20:22:35 PST
Thanks for catching this - you're referring to the 5 failing foreignObject tests, right? I actually think this only broke the last one (introduced in this patch, needs rebaselining) - the other 4 were introduced in r100045 and probably have been failing since (looks like they also need rebaselining on Leopard). I'll get on it first thing tomorrow, but I'd also appreciate some advice on how to do a better job at catching these in the future.
Note You need to log in before you can comment on or make changes to this bug.