Bug 72150 - Mouse Lock Navigator IDL
Summary: Mouse Lock Navigator IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vincent Scheib
URL:
Keywords:
Depends on: 72164
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-11 10:39 PST by Vincent Scheib
Modified: 2011-11-14 23:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (11.88 KB, patch)
2011-11-11 10:41 PST, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (11.91 KB, patch)
2011-11-12 22:29 PST, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Patch (12.00 KB, patch)
2011-11-12 22:35 PST, Vincent Scheib 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Scheib 2011-11-11 10:39:37 PST 
Mouse Lock Navigator IDL
Comment 1 Vincent Scheib 2011-11-11 10:41:45 PST 
Created attachment 114729 [details]
Patch
Comment 2 Vincent Scheib 2011-11-11 10:46:44 PST 
Specification: http://dvcs.w3.org/hg/webevents/raw-file/default/mouse-lock.html
Comment 3 Vincent Scheib 2011-11-11 11:09:58 PST 
Committed r99994: <http://trac.webkit.org/changeset/99994>
Comment 4 Vincent Scheib 2011-11-11 12:24:43 PST 
Reverted r99994 for reason:

Broke chromium windows build

Committed r100004: <http://trac.webkit.org/changeset/100004>
Comment 5 Vincent Scheib 2011-11-12 22:29:07 PST 
Created attachment 114853 [details]
Patch
Comment 6 Vincent Scheib 2011-11-12 22:31:21 PST 
Comment on attachment 114853 [details]
Patch

Windows build required an include for VoidCallback vs an empty declaration.
Comment 7 Vincent Scheib 2011-11-12 22:35:42 PST 
Created attachment 114854 [details]
Patch
Comment 8 Vincent Scheib 2011-11-13 07:26:18 PST 
Committed r100091: <http://trac.webkit.org/changeset/100091>
Comment 9 Darin Fisher (:fishd, Google) 2011-11-14 23:09:05 PST 
Comment on attachment 114854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114854&action=review

> Source/WebCore/page/MouseLockable.idl:31
> +        void webkitLock(in Element target, in [Callback, Optional] VoidCallback successCallback, in [Callback, Optional] VoidCallback failureCallback);

since MouseLockable is accessed via navigator.webkitPointer, it seems like you shouldn't need the webkit-prefix on any of these attributes.

elsewhere, we only prefix the top-level attribute.  see window.webkitNotifications for example.