Bug 72146 - [chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
Summary: [chromium] Remove 2 static initializers and 3 exit time destructors. Turn on ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 10:00 PST by Nico Weber
Modified: 2011-11-11 21:24 PST (History)
3 users (show)

See Also:

Attachments
Patch (10.58 KB, patch)
2011-11-11 10:01 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (12.94 KB, patch)
2011-11-11 10:38 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (12.88 KB, patch)
2011-11-11 20:20 PST, Nico Weber 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-11-11 10:00:12 PST 
[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
Comment 1 Nico Weber 2011-11-11 10:01:21 PST 
Created attachment 114721 [details]
Patch
Comment 2 Nico Weber 2011-11-11 10:28:23 PST 
Comment on attachment 114721 [details]
Patch

Two more on linux/clang…
Comment 3 Nico Weber 2011-11-11 10:38:21 PST 
Created attachment 114727 [details]
Patch
Comment 4 WebKit Review Bot 2011-11-11 18:09:22 PST 
Comment on attachment 114727 [details]
Patch

Rejecting attachment 114727 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10350677
Comment 5 James Robinson 2011-11-11 18:11:32 PST 
Comment on attachment 114727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114727&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

can't commit with this puppy
Comment 6 Nico Weber 2011-11-11 20:20:49 PST 
Created attachment 114816 [details]
Patch
Comment 7 WebKit Review Bot 2011-11-11 21:24:24 PST 
Comment on attachment 114816 [details]
Patch

Clearing flags on attachment: 114816

Committed r100070: <http://trac.webkit.org/changeset/100070>
Comment 8 WebKit Review Bot 2011-11-11 21:24:29 PST 
All reviewed patches have been landed.  Closing bug.