Bug 72143 - [EFL] Add more appcache functions to ewk_settings.
Summary: [EFL] Add more appcache functions to ewk_settings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on: 72884
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-11 09:41 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2011-11-21 07:42 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.71 KB, patch)
2011-11-11 09:43 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Rebased, working patch (6.61 KB, patch)
2011-11-18 07:10 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Doh, Kenneth had already r+ed the patch (6.67 KB, patch)
2011-11-21 05:44 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-11-11 09:41:39 PST
[EFL] Add more appcache functions to ewk_settings.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-11-11 09:43:53 PST
Created attachment 114718 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-13 15:05:09 PST
Comment on attachment 114718 [details]
Patch

Rejecting attachment 114718 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
s.h
Hunk #1 FAILED at 160.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_settings.h.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/efl/Skipped

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christia..." exit_code: 1

Full output: http://queues.webkit.org/results/10472040
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-11-18 07:10:46 PST
Created attachment 115803 [details]
Rebased, working patch
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-11-21 05:44:11 PST
Created attachment 116071 [details]
Doh, Kenneth had already r+ed the patch
Comment 5 WebKit Review Bot 2011-11-21 07:38:12 PST
Comment on attachment 116071 [details]
Doh, Kenneth had already r+ed the patch

Clearing flags on attachment: 116071

Committed r100915: <http://trac.webkit.org/changeset/100915>
Comment 6 WebKit Review Bot 2011-11-21 07:38:17 PST
All reviewed patches have been landed.  Closing bug.