RESOLVED FIXED 72139
[EFL] Clean up the web database-related functions in ewk_settings. 
https://bugs.webkit.org/show_bug.cgi?id=72139
Summary [EFL] Clean up the web database-related functions in ewk_settings.
Raphael Kubo da Costa (:rakuco)
Reported 2011-11-11 09:08:15 PST
[EFL] Clean up the web database-related functions in ewk_settings.
Attachments
Patch (3.88 KB, patch)
2011-11-11 09:10 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-11-11 09:10:07 PST
Created attachment 114714 [details] Patch
WebKit Review Bot
Comment 2 2011-11-13 14:51:44 PST
Comment on attachment 114714 [details] Patch Rejecting attachment 114714 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Parsed 3 diffs from patch file(s). patching file Source/WebKit/efl/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/efl/ewk/ewk_settings.cpp Hunk #2 succeeded at 47 with fuzz 1. Hunk #3 FAILED at 77. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_settings.cpp.rej patching file Source/WebKit/efl/ewk/ewk_settings.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christia..." exit_code: 1 Full output: http://queues.webkit.org/results/10476029
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-11-16 08:49:26 PST
Comment on attachment 114714 [details] Patch This one is also applying fine now, reflagging r?
WebKit Review Bot
Comment 4 2011-11-16 09:33:44 PST
Comment on attachment 114714 [details] Patch Clearing flags on attachment: 114714 Committed r100463: <http://trac.webkit.org/changeset/100463>
WebKit Review Bot
Comment 5 2011-11-16 09:33:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.