WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72137
[chromium-mac] Enable vertical text using Skia
https://bugs.webkit.org/show_bug.cgi?id=72137
Summary
[chromium-mac] Enable vertical text using Skia
Cary Clark
Reported
2011-11-11 09:00:41 PST
[chromium-mac] Enable vertical text using Skia
Attachments
Patch
(5.18 KB, patch)
2011-11-11 09:08 PST
,
Cary Clark
no flags
Details
Formatted Diff
Diff
Patch
(8.86 KB, patch)
2011-11-14 11:07 PST
,
Cary Clark
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Cary Clark
Comment 1
2011-11-11 09:08:46 PST
Created
attachment 114712
[details]
Patch
Stephen White
Comment 2
2011-11-11 09:20:12 PST
Comment on
attachment 114712
[details]
Patch Code looks good. Will this require any image rebaselines?
Cary Clark
Comment 3
2011-11-14 11:07:48 PST
Created
attachment 114989
[details]
Patch
Cary Clark
Comment 4
2011-11-14 11:09:50 PST
Added exceptions to test_expectations
WebKit Review Bot
Comment 5
2011-11-14 11:10:07 PST
Attachment 114989
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Last 3072 characters of output: /test_expectations.txt:3891: Path does not exist. fast/text/international/vertical-text-glyph-test.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3892: Path does not exist. fast/text/justify-ideograph-vertical.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3893: Path does not exist. fast/writing-mode/Kusa-Makura-background-canvas.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3894: Path does not exist. fast/writing-mode/border-vertical-lr.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3895: Path does not exist. fast/writing-mode/broken-ideographic-font.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3896: Path does not exist. fast/writing-mode/fallback-orientation.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3897: Path does not exist. fast/writing-mode/japanese-lr-text.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3898: Path does not exist. fast/writing-mode/japanese-rl-text-with-broken-font.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3899: Path does not exist. fast/writing-mode/japanese-rl-text-with-broken-font.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3900: Path does not exist. fast/writing-mode/japanese-rl-text.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3901: Path does not exist. fast/writing-mode/japanese-ruby-vertical-lr.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3902: Path does not exist. fast/writing-mode/japanese-ruby-vertical-rl.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3903: Path does not exist. fast/writing-mode/text-orientation-basic.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3904: Path does not exist. fast/writing-mode/vertical-align-table-baseline.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3905: Path does not exist. fast/writing-mode/vertical-baseline-alignment.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3906: Path does not exist. fast/writing-mode/vertical-font-fallback.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3908: Path does not exist. fast/loader/javascript-url-in-embed.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3910: Path does not exist. security/crypto-random-values-types.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3912: Path does not exist. media/track/track-webvtt-tc004-magic-header.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3914: Path does not exist. http/tests/inspector/resource-tree/resource-tree-frame-add.html [test/expectations] [2] Total errors found: 2158 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mike Reed
Comment 6
2011-11-14 11:15:38 PST
*all* style checks are busted for now, so it has to be ignored.
Stephen White
Comment 7
2011-11-14 11:53:07 PST
Comment on
attachment 114989
[details]
Patch Looks good. r=me; leaving cq off until the EWS bots have chewed on it a bit.
WebKit Review Bot
Comment 8
2011-11-15 08:17:43 PST
Comment on
attachment 114989
[details]
Patch Clearing flags on attachment: 114989 Committed
r100283
: <
http://trac.webkit.org/changeset/100283
>
WebKit Review Bot
Comment 9
2011-11-15 08:17:48 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug