[chromium-mac] Enable vertical text using Skia
Created attachment 114712 [details] Patch
Comment on attachment 114712 [details] Patch Code looks good. Will this require any image rebaselines?
Created attachment 114989 [details] Patch
Added exceptions to test_expectations
Attachment 114989 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Last 3072 characters of output: /test_expectations.txt:3891: Path does not exist. fast/text/international/vertical-text-glyph-test.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3892: Path does not exist. fast/text/justify-ideograph-vertical.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3893: Path does not exist. fast/writing-mode/Kusa-Makura-background-canvas.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3894: Path does not exist. fast/writing-mode/border-vertical-lr.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3895: Path does not exist. fast/writing-mode/broken-ideographic-font.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3896: Path does not exist. fast/writing-mode/fallback-orientation.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3897: Path does not exist. fast/writing-mode/japanese-lr-text.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3898: Path does not exist. fast/writing-mode/japanese-rl-text-with-broken-font.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3899: Path does not exist. fast/writing-mode/japanese-rl-text-with-broken-font.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3900: Path does not exist. fast/writing-mode/japanese-rl-text.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3901: Path does not exist. fast/writing-mode/japanese-ruby-vertical-lr.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3902: Path does not exist. fast/writing-mode/japanese-ruby-vertical-rl.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3903: Path does not exist. fast/writing-mode/text-orientation-basic.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3904: Path does not exist. fast/writing-mode/vertical-align-table-baseline.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3905: Path does not exist. fast/writing-mode/vertical-baseline-alignment.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3906: Path does not exist. fast/writing-mode/vertical-font-fallback.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3908: Path does not exist. fast/loader/javascript-url-in-embed.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3910: Path does not exist. security/crypto-random-values-types.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3912: Path does not exist. media/track/track-webvtt-tc004-magic-header.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3914: Path does not exist. http/tests/inspector/resource-tree/resource-tree-frame-add.html [test/expectations] [2] Total errors found: 2158 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
*all* style checks are busted for now, so it has to be ignored.
Comment on attachment 114989 [details] Patch Looks good. r=me; leaving cq off until the EWS bots have chewed on it a bit.
Comment on attachment 114989 [details] Patch Clearing flags on attachment: 114989 Committed r100283: <http://trac.webkit.org/changeset/100283>
All reviewed patches have been landed. Closing bug.