Bug 72132 - [EFL] Clean up the offline apps-related functions in ewk_settings.
Summary: [EFL] Clean up the offline apps-related functions in ewk_settings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on: 72127
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-11 08:30 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2011-11-16 07:59 PST (History)
6 users (show)

See Also:


Attachments
Patch (10.92 KB, patch)
2011-11-11 08:33 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-11-11 08:30:15 PST
[EFL] Clean up the offline apps-related functions in ewk_settings.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-11-11 08:33:01 PST
Created attachment 114704 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-13 14:54:43 PST
Comment on attachment 114704 [details]
Patch

Rejecting attachment 114704 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_settings.cpp.rej
patching file Source/WebKit/efl/ewk/ewk_settings.h
patching file Source/WebKit/efl/ewk/ewk_view.cpp
patching file Source/WebKit/efl/ewk/ewk_view.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christia..." exit_code: 1

Full output: http://queues.webkit.org/results/10473037
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-11-16 07:16:08 PST
Comment on attachment 114704 [details]
Patch

Seems to be applying fine after some related patches got in. Flagging cq? again.
Comment 4 WebKit Review Bot 2011-11-16 07:58:57 PST
Comment on attachment 114704 [details]
Patch

Clearing flags on attachment: 114704

Committed r100452: <http://trac.webkit.org/changeset/100452>
Comment 5 WebKit Review Bot 2011-11-16 07:59:03 PST
All reviewed patches have been landed.  Closing bug.