Bug 72124 - REGRESSION(r99964): Broke too many Qt tests (Requested by tronical_ on #webkit).
Summary: REGRESSION(r99964): Broke too many Qt tests (Requested by tronical_ on #webkit).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 67773
  Show dependency treegraph
 
Reported: 2011-11-11 07:49 PST by WebKit Review Bot
Modified: 2011-11-13 13:21 PST (History)
5 users (show)

See Also:


Attachments
ROLLOUT of r99964 (145.38 KB, patch)
2011-11-11 07:49 PST, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-11-11 07:49:04 PST
http://trac.webkit.org/changeset/99964 broke the build:
Broke too many Qt tests (Requested by tronical_ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-11-11 07:49:33 PST
Created attachment 114698 [details]
ROLLOUT of r99964

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Simon Hausmann 2011-11-11 07:52:23 PST
Comment on attachment 114698 [details]
ROLLOUT of r99964

Clearing flags on attachment: 114698

Committed r99968: <http://trac.webkit.org/changeset/99968>
Comment 3 Simon Hausmann 2011-11-11 07:52:32 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2011-11-13 07:27:45 PST
I don't know how, but it broke the build on the Qt SL bot on build.webkit.org:
http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/4094/steps/compile-webkit/logs/stdio

But the build works fine on the Qt SL bot on build.webkit.sed.hu.

Maybe a build system bug caused it, I don't know.
Comment 5 Tor Arne Vestbø 2011-11-13 12:38:59 PST
The rollout or the original patch?
Comment 6 Simon Hausmann 2011-11-13 13:21:25 PST
(In reply to comment #5)
> The rollout or the original patch?

The rollout broke the build: http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/4094

It's strange, it's in a totally unrelated file, qmake was run on the .pro file but somehow the generated makefile doesn't compile & link in the moc generated code.