Bug 72124 – REGRESSION(r99964): Broke too many Qt tests (Requested by tronical_ on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/99964 broke the build:
Broke too many Qt tests (Requested by tronical_ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 114698 [details]
ROLLOUT of r99964

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Simon Hausmann]

Comment on attachment 114698 [details]
ROLLOUT of r99964

Clearing flags on attachment: 114698

Committed r99968: <http://trac.webkit.org/changeset/99968>

[Simon Hausmann]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

I don't know how, but it broke the build on the Qt SL bot on build.webkit.org:
http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/4094/steps/compile-webkit/logs/stdio

But the build works fine on the Qt SL bot on build.webkit.sed.hu.

Maybe a build system bug caused it, I don't know.

[Tor Arne Vestbø]

The rollout or the original patch?

[Simon Hausmann]

(In reply to comment #5)
> The rollout or the original patch?

The rollout broke the build: http://build.webkit.org/builders/Qt%20SnowLeopard%20Release/builds/4094

It's strange, it's in a totally unrelated file, qmake was run on the .pro file but somehow the generated makefile doesn't compile & link in the moc generated code.