Bug 72118 - Web Inspector: make search in DOM panel scale.
Summary: Web Inspector: make search in DOM panel scale.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 05:28 PST by Pavel Feldman
Modified: 2011-11-11 07:22 PST (History)
11 users (show)

See Also:

Attachments
Patch (38.92 KB, patch)
2011-11-11 05:41 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (39.72 KB, patch)
2011-11-11 06:49 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (39.18 KB, patch)
2011-11-11 07:20 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-11-11 05:28:50 PST 
Patch to follow.
Comment 1 Pavel Feldman 2011-11-11 05:41:11 PST 
Created attachment 114685 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-11 05:47:27 PST 
Attachment 114685 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InspectorDOMAgent.h:130:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDOMAgent.cpp:987:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Feldman 2011-11-11 06:49:32 PST 
Created attachment 114694 [details]
Patch
Comment 4 WebKit Review Bot 2011-11-11 06:52:43 PST 
Attachment 114694 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InspectorDOMAgent.h:130:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDOMAgent.cpp:990:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Yury Semikhatsky 2011-11-11 07:01:17 PST 
Comment on attachment 114694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114694&action=review

> Source/WebCore/inspector/front-end/ElementsPanel.js:366
> +        var nextCallback = jumpToNextOnEmpty ? this.jumpToNextSearchResult.bind(this) : this.jumpToPreviousSearchResult.bind(this);

No need to bind these methods just to call them below.

> Source/WebCore/inspector/front-end/ElementsPanel.js:370
> +            nextCallback();

if (jumpToNextOnEmpty)
   this.jumpToNextSearchResult();
else
   this.jumpToPreviousSearchResult();
Comment 6 Yury Semikhatsky 2011-11-11 07:18:17 PST 
Comment on attachment 114694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114694&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:982
> +    resultsIt->second.clear();

Remove this line?
Comment 7 Pavel Feldman 2011-11-11 07:20:03 PST 
Created attachment 114695 [details]
Patch
Comment 8 WebKit Review Bot 2011-11-11 07:21:32 PST 
Attachment 114695 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InspectorDOMAgent.h:130:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDOMAgent.cpp:989:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Pavel Feldman 2011-11-11 07:22:52 PST 
Committed r99965: <http://trac.webkit.org/changeset/99965>