Bug 72114 - [chromium] MediaStream API: Allow for null WebPeerConnectionHandler
Summary: [chromium] MediaStream API: Allow for null WebPeerConnectionHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 04:59 PST by Tommy Widenflycht
Modified: 2011-11-14 11:13 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.88 KB, patch)
2011-11-11 05:03 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (5.96 KB, patch)
2011-11-14 03:01 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2011-11-11 04:59:30 PST 
Fixing crash if WebKitPlatformSupport returns a null WebPeerConnectionHandler to PeerConnectionHandlerInternal.
Comment 1 Tommy Widenflycht 2011-11-11 05:03:13 PST 
Created attachment 114675 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-11 05:04:50 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Adam Barth 2011-11-13 22:13:55 PST 
Comment on attachment 114675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114675&action=review

> Source/WebKit/chromium/public/WebKitPlatformSupport.h:328
> +    // May return null.

It would be nice to explain the situations in which this function can return null.
Comment 4 Tommy Widenflycht 2011-11-14 03:01:27 PST 
Created attachment 114908 [details]
Patch
Comment 5 Tommy Widenflycht 2011-11-14 03:02:42 PST 
Comment on attachment 114675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114675&action=review

>> Source/WebKit/chromium/public/WebKitPlatformSupport.h:328
>> +    // May return null.
> 
> It would be nice to explain the situations in which this function can return null.

Fixed.
Comment 6 Adam Barth 2011-11-14 08:42:01 PST 
Comment on attachment 114908 [details]
Patch

Technically we need fishd to review, but given that you're just adding a comment to the API, I think it's fine.
Comment 7 WebKit Review Bot 2011-11-14 10:06:50 PST 
Comment on attachment 114908 [details]
Patch

Clearing flags on attachment: 114908

Committed r100162: <http://trac.webkit.org/changeset/100162>
Comment 8 WebKit Review Bot 2011-11-14 10:06:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Darin Fisher (:fishd, Google) 2011-11-14 11:13:45 PST 
Comment on attachment 114908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114908&action=review

> Source/WebKit/chromium/public/WebKitPlatformSupport.h:328
> +    // May return null if WebRTC functionality is not avaliable or out of resources.

nit: "avaliable" -> available