Bug 72113 - [Qt][WK2] Remove QWebNavigationController
Summary: [Qt][WK2] Remove QWebNavigationController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 04:28 PST by Simon Hausmann
Modified: 2011-11-11 04:40 PST (History)
4 users (show)

See Also:

Attachments
[Qt][WK2] Remove QWebNavigationController (24.57 KB, patch)
2011-11-11 04:32 PST, Simon Hausmann 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2011-11-11 04:28:38 PST 
[Qt][WK2] Remove QWebNavigationController
Comment 1 Simon Hausmann 2011-11-11 04:32:23 PST 
Created attachment 114669 [details]
[Qt][WK2] Remove QWebNavigationController
Comment 2 Alexis Menard (darktears) 2011-11-11 04:34:34 PST 
Comment on attachment 114669 [details]
[Qt][WK2] Remove QWebNavigationController

View in context: https://bugs.webkit.org/attachment.cgi?id=114669&action=review

LGTM goo!

> Source/WebKit/qt/ChangeLog:9
> +        (WebKitQmlPlugin::registerTypes): Don't register QWebNavigationController with qml.

nitpick isn't it QML :D.
Comment 3 Andreas Kling 2011-11-11 04:37:30 PST 
Comment on attachment 114669 [details]
[Qt][WK2] Remove QWebNavigationController

LGTM. Good riddance :)
Comment 4 Simon Hausmann 2011-11-11 04:40:16 PST 
Comment on attachment 114669 [details]
[Qt][WK2] Remove QWebNavigationController

Clearing flags on attachment: 114669

Committed r99946: <http://trac.webkit.org/changeset/99946>
Comment 5 Simon Hausmann 2011-11-11 04:40:24 PST 
All reviewed patches have been landed.  Closing bug.