Bug 72111 - Test that calling document collection getters repeatedly yields the same objects.
Summary: Test that calling document collection getters repeatedly yields the same obje...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 04:15 PST by Andreas Kling
Modified: 2011-12-07 08:17 PST (History)
5 users (show)

See Also:

Attachments
Patchy patch (3.12 KB, patch)
2011-11-11 04:19 PST, Andreas Kling 		koivisto: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-11 04:15:13 PST 
As a follow-up to r99869 (bug 71956), Sam pointed out that we should have a test verifying that "document.links == document.links" and so on.
Comment 1 Andreas Kling 2011-11-11 04:19:57 PST 
Created attachment 114666 [details]
Patchy patch
Comment 2 Antti Koivisto 2011-11-11 05:23:09 PST 
Comment on attachment 114666 [details]
Patchy patch

r=me
Comment 3 Alexey Proskuryakov 2011-11-11 10:26:36 PST 
Why not ===?
Comment 4 Alexey Proskuryakov 2011-11-11 10:28:39 PST 
Comment on attachment 114666 [details]
Patchy patch

Also, please merge the script into document-collection-idempotence.html, there is no good in keeping it separate.

The easiest way to start a script test is with make-new-script-test script, which will write out boilerplate with proper relative paths.
Comment 5 WebKit Review Bot 2011-11-11 18:11:03 PST 
Comment on attachment 114666 [details]
Patchy patch

Attachment 114666 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10452048

New failing tests:
fast/dom/document-collection-idempotence.html
Comment 6 Andreas Kling 2011-12-07 08:17:43 PST 
I'll fold this test into bug 71956 once I get back to fixing the perf regression it introduced.