Bug 72105 - Finish SVGLengthContext conversion in svg/
Summary: Finish SVGLengthContext conversion in svg/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 71780
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-11 02:49 PST by Nikolas Zimmermann
Modified: 2011-11-12 02:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (36.04 KB, patch)
2011-11-11 08:23 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2011-11-11 02:49:30 PST 
Remove the operator SVGLengthContext() from SVGElement, and move the last call-sites to pass SVGLengthContext instead of const SVGElement*.
Comment 1 Nikolas Zimmermann 2011-11-11 08:23:00 PST 
Created attachment 114703 [details]
Patch

This finished the introduction of SVGLengthContext. Doesn't affect any tests yet.
Comment 2 Antti Koivisto 2011-11-12 02:36:03 PST 
Comment on attachment 114703 [details]
Patch

r=me
Comment 3 Nikolas Zimmermann 2011-11-12 02:39:37 PST 
Comment on attachment 114703 [details]
Patch

Clearing flags, landed in r100075.
Comment 4 Nikolas Zimmermann 2011-11-12 02:51:12 PST 
The build is broken. My patch does touch CodeGeneratorObjC.pm, but it is NOT my patch fault.
paroga said on IRC that his build failed as well, locally, before my patch, with a fresh checkout.


Public API change. There are missing public properties and/or methods from the "DOMHTMLAreaElement" class.
@property(copy) NSString *accessKey;
Died at WebCore/bindings/scripts//CodeGeneratorObjC.pm line 323.
Public API change. There are missing public properties and/or methods from the "DOMHTMLAnchorElement" class.
@property(copy) NSString *accessKey;
Died at WebCore/bindings/scripts//CodeGeneratorObjC.pm line 323.
....