RESOLVED FIXED 72101
Make GraphicsContext3D::makeContextCurrent return bool 
https://bugs.webkit.org/show_bug.cgi?id=72101
Summary Make GraphicsContext3D::makeContextCurrent return bool
Nat Duca
Reported 2011-11-11 01:23:40 PST
Make GraphicsContext3D::makeContextCurrent return bool
Attachments
Patch (7.18 KB, patch)
2011-11-11 01:24 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.38 KB, patch)
2011-11-11 19:46 PST, Nat Duca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nat Duca
Comment 1 2011-11-11 01:24:22 PST
Created attachment 114647 [details] Patch
Nat Duca
Comment 2 2011-11-11 01:25:47 PST
This is needed to gracefully recover when making a context current fails.
Kenneth Russell
Comment 3 2011-11-11 12:39:18 PST
Comment on attachment 114647 [details] Patch Looks fine. This API change more accurately reflects reality. Please fix the Mac build failure. r=me
Nat Duca
Comment 4 2011-11-11 19:46:57 PST
Created attachment 114815 [details] Patch for landing
Nico Weber
Comment 5 2011-11-11 20:35:13 PST
Comment on attachment 114815 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=114815&action=review > Source/WebCore/platform/graphics/gtk/GraphicsContext3DGtk.cpp:141 > return; This will fail to compile. > Source/WebCore/platform/graphics/gtk/GraphicsContext3DPrivate.cpp:240 > return; As will this and the other returns in this function; and it needs a return true at the end. > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:268 > CGLSetCurrentContext(m_contextObj); Maybe return false if CGLSetCurrentContext() doesn't return kCGLNoError?
WebKit Review Bot
Comment 6 2011-11-11 20:45:16 PST
Comment on attachment 114815 [details] Patch for landing Clearing flags on attachment: 114815 Committed r100068: <http://trac.webkit.org/changeset/100068>
WebKit Review Bot
Comment 7 2011-11-11 20:45:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.