Created attachment 114638 [details] Patch to fix this bug I've been working with the WebSocket protocol and noticed that sometimes getBodyContents is broken. I dug into this a little more and noticed that in WebInspectorStubs.js it was just taking the result argument (object) and converting them into an array. Well, objects aren't ordered. The reason this worked most of the times is that most commands have 1 or 0 result arguments. I patched CodeGeneratorInspector.py to generate correct code. Patch is attached. (also posted on chromium http://code.google.com/p/chromium/issues/detail?id=103881)
Comment on attachment 114638 [details] Patch to fix this bug View in context: https://bugs.webkit.org/attachment.cgi?id=114638&action=review lgtm > Source/WebCore/inspector/CodeGeneratorInspector.py:1029 > if (this.dumpInspectorTimeStats) { > - var wrappedCallback = this._callbacks[messageObject.id]; > - wrappedCallback.methodName = messageObject.method; > wrappedCallback.sendRequestTime = Date.now(); > } style nits: curly bracers are not required
Created attachment 114689 [details] Patch
Created attachment 114693 [details] Patch
Committed r99960: <http://trac.webkit.org/changeset/99960>