Bug 72096 – Web Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[michael lewis]

Created attachment 114638 [details]
Patch to fix this bug

I've been working with the WebSocket protocol and noticed that sometimes getBodyContents is broken.

I dug into this a little more and noticed that in WebInspectorStubs.js it was just taking the result argument (object) and converting them into an array.  Well, objects aren't ordered.  The reason this worked most of the times is that most commands have 1 or 0 result arguments.

I patched CodeGeneratorInspector.py to generate correct code.

Patch is attached.


(also posted on chromium http://code.google.com/p/chromium/issues/detail?id=103881)

[Ilya Tikhonovsky]

Comment on attachment 114638 [details]
Patch to fix this bug

View in context: https://bugs.webkit.org/attachment.cgi?id=114638&action=review

lgtm

> Source/WebCore/inspector/CodeGeneratorInspector.py:1029
>          if (this.dumpInspectorTimeStats) {
> -            var wrappedCallback = this._callbacks[messageObject.id];
> -            wrappedCallback.methodName = messageObject.method;
>              wrappedCallback.sendRequestTime = Date.now();
>          }

style nits: curly bracers are not required

[Ilya Tikhonovsky]

Created attachment 114689 [details]
Patch

[Ilya Tikhonovsky]

Created attachment 114693 [details]
Patch

[Ilya Tikhonovsky]

Committed r99960: <http://trac.webkit.org/changeset/99960>