Bug 72082 - ApplicationCache manifest should work with any MIME type
Summary: ApplicationCache manifest should work with any MIME type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Nordman
URL:
Keywords:
: 72449 74629 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-10 18:14 PST by Alexey Proskuryakov
Modified: 2011-12-15 12:42 PST (History)
8 users (show)

See Also:


Attachments
mime (6.59 KB, patch)
2011-11-16 12:56 PST, Michael Nordman
ap: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
mime (7.38 KB, patch)
2011-11-16 16:01 PST, Michael Nordman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-11-10 18:14:44 PST
The spec changed, it no longer requires MIME type to be text/cache-manifest. Boo!

http://html5.org/tools/web-apps-tracker?from=6822&to=6823
Comment 1 Alexey Proskuryakov 2011-11-16 00:34:52 PST
*** Bug 72449 has been marked as a duplicate of this bug. ***
Comment 2 Michael Nordman 2011-11-16 12:56:40 PST
Created attachment 115428 [details]
mime
Comment 3 WebKit Review Bot 2011-11-16 14:53:35 PST
Comment on attachment 115428 [details]
mime

Rejecting attachment 115428 [details] from commit-queue.

New failing tests:
http/tests/appcache/wrong-content-type.html
Full output: http://queues.webkit.org/results/10499141
Comment 4 Michael Nordman 2011-11-16 15:01:41 PST
The irony is that a chromium cl to ignore the mime-type waiting for this webkit patch to land, and instead of just skipping the test for chromium i choose to update webcore's logic to match... and of course the commit bot rejects it. The joy of multi-sided patches :)
Comment 5 WebKit Review Bot 2011-11-16 15:26:24 PST
Comment on attachment 115428 [details]
mime

Attachment 115428 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10505097

New failing tests:
http/tests/appcache/wrong-content-type.html
Comment 6 Michael Nordman 2011-11-16 16:01:33 PST
Created attachment 115468 [details]
mime

temporarily skip this test in chromium's expecations file
Comment 7 Alexey Proskuryakov 2011-11-16 16:06:22 PST
Comment on attachment 115468 [details]
mime

Setting r+ - commit queue won't land with only a cq+ unless you manually in reviewer name in ChangeLog.
Comment 8 WebKit Review Bot 2011-11-16 16:06:44 PST
Comment on attachment 115468 [details]
mime

Rejecting attachment 115468 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/10485928
Comment 9 WebKit Review Bot 2011-11-16 17:46:34 PST
Comment on attachment 115468 [details]
mime

Clearing flags on attachment: 115468

Committed r100541: <http://trac.webkit.org/changeset/100541>
Comment 10 WebKit Review Bot 2011-11-16 17:46:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Michael Nordman 2011-12-15 12:42:31 PST
*** Bug 74629 has been marked as a duplicate of this bug. ***