Bug 72069 - ASSERT when outdenting styled line break
Summary: ASSERT when outdenting styled line break
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-11-10 15:54 PST by Enrica Casucci
Modified: 2011-11-10 17:26 PST (History)
0 users

See Also:

Attachments
Patch (5.60 KB, patch)
2011-11-10 16:48 PST, Enrica Casucci 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2011-11-10 15:54:34 PST 
Given the following markup:

<body contenteditable>
     <blockquote style….>
           <img>
          <br>
           <b><br></br>
     </blockquote>
</body>

placing the selection on the last <br> and performing and outdent command will trigger an assert.
Comment 1 Enrica Casucci 2011-11-10 15:57:46 PST 
<rdar://problem/10429739>
Comment 2 Enrica Casucci 2011-11-10 16:48:28 PST 
Created attachment 114602 [details]
Patch
Comment 3 Ryosuke Niwa 2011-11-10 16:55:39 PST 
Comment on attachment 114602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114602&action=review

> Source/WebCore/ChangeLog:10
> +        the assert.

Could you fit "the assert" on the previous line to avoid an awkward line break?

> Source/WebCore/ChangeLog:12
> +        Reviewed by NOBODY (OOPS!).

This line should appear before the description.
Comment 4 Enrica Casucci 2011-11-10 16:59:55 PST 
(In reply to comment #3)
> (From update of attachment 114602 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114602&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        the assert.
> 
> Could you fit "the assert" on the previous line to avoid an awkward line break?
> 
> > Source/WebCore/ChangeLog:12
> > +        Reviewed by NOBODY (OOPS!).
> 
> This line should appear before the description.

Will do. Thanks for the review!
Comment 5 Enrica Casucci 2011-11-10 17:26:50 PST 
Committed revision 99918.