REOPENED72054
Could round rather than truncate in compileClampDoubleToByte? 
https://bugs.webkit.org/show_bug.cgi?id=72054
Summary Could round rather than truncate in compileClampDoubleToByte?
Gavin Barraclough
Reported 2011-11-10 13:48:43 PST
There is a +0.5 followed by truncate in the DFG JIT, may be able to replace this with a round.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-07-21 14:37:31 PDT
https://github.com/WebKit/WebKit/blob/main/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp#L3555 It is still present in the Source Code.
Keith Miller
Comment 2 2023-08-11 10:29:07 PDT
This also has the wrong semantics. It should be a round to nearest not a round to infinity. Uploading a patch now.
Keith Miller
Comment 3 2023-08-11 10:34:06 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16609
EWS
Comment 4 2023-08-21 11:56:55 PDT
Committed 267100@main (c55d0673236c): <https://commits.webkit.org/267100@main> Reviewed commits have been landed. Closing PR #16609 and removing active labels.
Radar WebKit Bug Importer
Comment 5 2023-08-21 11:57:16 PDT
<rdar://problem/114208146>
WebKit Commit Bot
Comment 6 2023-08-22 11:21:36 PDT
Re-opened since this is blocked by bug 260534
Note You need to log in before you can comment on or make changes to this bug.