RESOLVED FIXED72050
Add ARMv7 register info for the DFG JIT 
https://bugs.webkit.org/show_bug.cgi?id=72050
Summary Add ARMv7 register info for the DFG JIT
Gavin Barraclough
Reported 2011-11-10 13:16:47 PST
Update DFGFPRInfo/DFGGPRInfo.
Attachments
Fix (9.25 KB, patch)
2011-11-10 13:17 PST, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-11-10 13:17:23 PST
Created attachment 114553 [details] Fix
Geoffrey Garen
Comment 2 2011-11-10 13:19:17 PST
Comment on attachment 114553 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=114553&action=review r=me > Source/JavaScriptCore/dfg/DFGFPRInfo.h:54 > + // Only X86_64 passed aguments in xmm registers typo: passes. > Source/JavaScriptCore/dfg/DFGFPRInfo.h:60 > + // Only X86 the return will actually be of the x87 stack, typo: on. twice.
WebKit Review Bot
Comment 3 2011-11-10 13:25:16 PST
Attachment 114553 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGGPRInfo.h:342: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/dfg/DFGGPRInfo.h:343: One space before end of line comments [whitespace/comments] [5] Source/JavaScriptCore/dfg/DFGFPRInfo.h:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 4 2011-11-10 13:41:34 PST
Fixed in r99895
Note You need to log in before you can comment on or make changes to this bug.