Bug 72050 - Add ARMv7 register info for the DFG JIT
Summary: Add ARMv7 register info for the DFG JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 13:16 PST by Gavin Barraclough
Modified: 2011-11-10 13:41 PST (History)
1 user (show)

See Also:


Attachments
Fix (9.25 KB, patch)
2011-11-10 13:17 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-11-10 13:16:47 PST
Update DFGFPRInfo/DFGGPRInfo.
Comment 1 Gavin Barraclough 2011-11-10 13:17:23 PST
Created attachment 114553 [details]
Fix
Comment 2 Geoffrey Garen 2011-11-10 13:19:17 PST
Comment on attachment 114553 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=114553&action=review

r=me

> Source/JavaScriptCore/dfg/DFGFPRInfo.h:54
> +    // Only X86_64 passed aguments in xmm registers

typo: passes.

> Source/JavaScriptCore/dfg/DFGFPRInfo.h:60
> +    // Only X86 the return will actually be of the x87 stack,

typo: on. twice.
Comment 3 WebKit Review Bot 2011-11-10 13:25:16 PST
Attachment 114553 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGGPRInfo.h:342:  One space before end of line comments  [whitespace/comments] [5]
Source/JavaScriptCore/dfg/DFGGPRInfo.h:343:  One space before end of line comments  [whitespace/comments] [5]
Source/JavaScriptCore/dfg/DFGFPRInfo.h:129:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gavin Barraclough 2011-11-10 13:41:34 PST
Fixed in r99895