Bug 72040 - Fix sampling counters on ARMv7, move add64 functionality to macro assembler
Summary: Fix sampling counters on ARMv7, move add64 functionality to macro assembler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 12:16 PST by Gavin Barraclough
Modified: 2011-11-10 12:24 PST (History)
0 users

See Also:

Attachments
Fix (9.41 KB, patch)
2011-11-10 12:18 PST, Gavin Barraclough 		ggaren: review+
barraclough: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-11-10 12:16:43 PST 
The ability to add an integer to a uint64_t in memory is poorly copied in multiple places & ifdef'ed on architecture, addWithCarry32 is also a badly designed interface since add32 is not required to set flags (we have no concept of flags in the macro assembler interface).
Comment 1 Gavin Barraclough 2011-11-10 12:18:37 PST 
Created attachment 114540 [details]
Fix
Comment 2 Geoffrey Garen 2011-11-10 12:21:52 PST 
Comment on attachment 114540 [details]
Fix

r=me
Comment 3 Gavin Barraclough 2011-11-10 12:24:28 PST 
Fixed in r99888