Bug 72035 - De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
Summary: De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScrip...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 11:03 PST by Mark Hahnenberg
Modified: 2011-11-11 11:37 PST (History)
0 users

See Also:

Attachments
Patch (17.59 KB, patch)
2011-11-10 12:09 PST, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-11-10 11:03:47 PST 
We're trying to de-virtualize JSGlobalObject, so in order to do that we need to de-virtualize these three functions.  One way to do that would be to provide a method table just for JSGlobalObject to prevent pollution of the primary MethodTable in ClassInfo just for the sake of JSGlobalObject (and JSDOMWindowBase).
Comment 1 Mark Hahnenberg 2011-11-10 12:09:48 PST 
Created attachment 114538 [details]
Patch
Comment 2 Geoffrey Garen 2011-11-10 15:44:04 PST 
Comment on attachment 114538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114538&action=review

r=me

> Source/WebCore/bindings/js/JSDOMWindowBase.cpp:60
> +    m_globalObjectMethodTable = &s_globalObjectMethodTable;

Initialization syntax is better.
Comment 3 Mark Hahnenberg 2011-11-11 11:37:07 PST 
Committed r99997: <http://trac.webkit.org/changeset/99997>