Bug 72028 - [chromium] Plumb through partial swap
Summary: [chromium] Plumb through partial swap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 67341
  Show dependency treegraph
 
Reported: 2011-11-10 08:11 PST by Jonathan Backer
Modified: 2011-11-16 10:41 PST (History)
7 users (show)

See Also:


Attachments
Patch (9.28 KB, patch)
2011-11-10 08:13 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff
Patch (8.53 KB, patch)
2011-11-11 11:01 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff
Patch (8.50 KB, patch)
2011-11-11 13:09 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff
Patch (8.48 KB, patch)
2011-11-14 08:07 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Backer 2011-11-10 08:11:39 PST
[chromium] NOT FOR REVIEW Plumb through partial swap
Comment 1 Jonathan Backer 2011-11-10 08:13:21 PST
Created attachment 114505 [details]
Patch
Comment 2 Jonathan Backer 2011-11-10 08:16:28 PST
Here's the chromium side that has to land first: http://codereview.chromium.org/8512005/
Comment 3 Jonathan Backer 2011-11-11 10:53:32 PST
Chromium side has landed.
Comment 4 Jonathan Backer 2011-11-11 11:01:40 PST
Created attachment 114734 [details]
Patch
Comment 5 WebKit Review Bot 2011-11-11 11:02:51 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 6 Kenneth Russell 2011-11-11 12:36:48 PST
Comment on attachment 114734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114734&action=review

Looks fine overall; one question/comment. r- for the ChangeLog issue; please upload a new patch fixing that.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This OOPS needs to be removed from the ChangeLog.

> Source/WebKit/chromium/public/WebGraphicsContext3D.h:166
> +    // GL_CHROMIUM_post_sub_buffer - Copies part of the back buffer to the front buffer.

This documentation should (also) be added to the declaration of the extension in Chromium's gl2ext.h.

Has chromium_rev in Source/WebKit/chromium/DEPS already been rolled forward to the revision containing the concrete implementations of this method?
Comment 7 Jonathan Backer 2011-11-11 13:09:16 PST
Created attachment 114756 [details]
Patch
Comment 8 Jonathan Backer 2011-11-11 13:11:07 PST
(In reply to comment #6)
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (OOPS!)
> 
> This OOPS needs to be removed from the ChangeLog.

Fixed.

> 
> > Source/WebKit/chromium/public/WebGraphicsContext3D.h:166
> > +    // GL_CHROMIUM_post_sub_buffer - Copies part of the back buffer to the front buffer.
> 
> This documentation should (also) be added to the declaration of the extension in Chromium's gl2ext.h.

CL is in the CQ (http://codereview.chromium.org/8536025/)
 
> Has chromium_rev in Source/WebKit/chromium/DEPS already been rolled forward to the revision containing the concrete implementations of this method?

WK gardener rolled: http://trac.webkit.org/changeset/100010
Comment 9 Kenneth Russell 2011-11-11 13:12:39 PST
Comment on attachment 114756 [details]
Patch

Thanks, looks great. r=me
Comment 10 Jonathan Backer 2011-11-14 08:07:43 PST
Created attachment 114950 [details]
Patch
Comment 11 Fady Samuel 2011-11-14 08:30:58 PST
Comment on attachment 114950 [details]
Patch

Clearing flags on attachment: 114950

Committed r100146: <http://trac.webkit.org/changeset/100146>
Comment 12 Fady Samuel 2011-11-14 08:31:05 PST
All reviewed patches have been landed.  Closing bug.