Bug 72028 – [chromium] Plumb through partial swap

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jonathan Backer]

[chromium] NOT FOR REVIEW Plumb through partial swap

[Jonathan Backer]

Created attachment 114505 [details]
Patch

[Jonathan Backer]

Here's the chromium side that has to land first: http://codereview.chromium.org/8512005/

[Jonathan Backer]

Chromium side has landed.

[Jonathan Backer]

Created attachment 114734 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Kenneth Russell]

Comment on attachment 114734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114734&action=review

Looks fine overall; one question/comment. r- for the ChangeLog issue; please upload a new patch fixing that.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This OOPS needs to be removed from the ChangeLog.

> Source/WebKit/chromium/public/WebGraphicsContext3D.h:166
> +    // GL_CHROMIUM_post_sub_buffer - Copies part of the back buffer to the front buffer.

This documentation should (also) be added to the declaration of the extension in Chromium's gl2ext.h.

Has chromium_rev in Source/WebKit/chromium/DEPS already been rolled forward to the revision containing the concrete implementations of this method?

[Jonathan Backer]

Created attachment 114756 [details]
Patch

[Jonathan Backer]

(In reply to comment #6)
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (OOPS!)
> 
> This OOPS needs to be removed from the ChangeLog.

Fixed.

> 
> > Source/WebKit/chromium/public/WebGraphicsContext3D.h:166
> > +    // GL_CHROMIUM_post_sub_buffer - Copies part of the back buffer to the front buffer.
> 
> This documentation should (also) be added to the declaration of the extension in Chromium's gl2ext.h.

CL is in the CQ (http://codereview.chromium.org/8536025/)
 
> Has chromium_rev in Source/WebKit/chromium/DEPS already been rolled forward to the revision containing the concrete implementations of this method?

WK gardener rolled: http://trac.webkit.org/changeset/100010

[Kenneth Russell]

Comment on attachment 114756 [details]
Patch

Thanks, looks great. r=me

[Jonathan Backer]

Created attachment 114950 [details]
Patch

[Fady Samuel]

Comment on attachment 114950 [details]
Patch

Clearing flags on attachment: 114950

Committed r100146: <http://trac.webkit.org/changeset/100146>

[Fady Samuel]

All reviewed patches have been landed.  Closing bug.