RESOLVED FIXED Bug 72026
[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest 
https://bugs.webkit.org/show_bug.cgi?id=72026
Summary [chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
Iain Merrick
Reported 2011-11-10 06:59:35 PST
[chromium] Fix incorrect usage of ASSERT in CCLayerTreeHostTest
Attachments
Patch (3.18 KB, patch)
2011-11-10 07:03 PST, Iain Merrick 		no flags
DetailsFormatted DiffDiff
Rebased (3.19 KB, patch)
2011-11-14 03:48 PST, Iain Merrick 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Iain Merrick
Comment 1 2011-11-10 07:03:27 PST
Created attachment 114492 [details] Patch
WebKit Review Bot
Comment 2 2011-11-10 09:15:02 PST
Comment on attachment 114492 [details] Patch Rejecting attachment 114492 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/trunk@9897; UUID don't match and there is local changes in /mnt/git/webkit-commit-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 111. Full output: http://queues.webkit.org/results/10414015
WebKit Review Bot
Comment 3 2011-11-11 14:03:31 PST
Comment on attachment 114492 [details] Patch Rejecting attachment 114492 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: reviewer', u'Tony Gentilcore', u'--..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp Hunk #6 FAILED at 340. 1 out of 6 hunks FAILED -- saving rejects to file Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Gentilcore', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10396535
Iain Merrick
Comment 4 2011-11-14 03:48:05 PST
Created attachment 114914 [details] Rebased
WebKit Review Bot
Comment 5 2011-11-14 04:41:19 PST
Comment on attachment 114914 [details] Rebased Clearing flags on attachment: 114914 Committed r100127: <http://trac.webkit.org/changeset/100127>
WebKit Review Bot
Comment 6 2011-11-14 04:41:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.