WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72022
Web Inspector: [SuggestBox] Correctly position the box under the first character of the suggestion prefix.
https://bugs.webkit.org/show_bug.cgi?id=72022
Summary
Web Inspector: [SuggestBox] Correctly position the box under the first charac...
Alexander Pavlov (apavlov)
Reported
Thursday, November 10, 2011 2:27:31 PM UTC
Patch to follow
Attachments
Patch
(7.17 KB, patch)
2011-11-10 08:15 PST
,
Alexander Pavlov (apavlov)
no flags
Details
Formatted Diff
Diff
Patch
(10.32 KB, patch)
2011-11-10 08:59 PST
,
Alexander Pavlov (apavlov)
pfeldman
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1
Thursday, November 10, 2011 4:15:39 PM UTC
Created
attachment 114506
[details]
Patch
Pavel Feldman
Comment 2
Thursday, November 10, 2011 4:20:18 PM UTC
Comment on
attachment 114506
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=114506&action=review
> Source/WebCore/inspector/front-end/TextPrompt.js:869 > + * @param {*=} anchorBox
This is not nice.
> Source/WebCore/inspector/front-end/TextPrompt.js:884 > + anchorBox = this._anchorBox || this._inputElement.boxInWindow(window, this._parentElement);
This is a strange control flow: if given, use, otherwise check if it has been used, otherwise do something.
Alexander Pavlov (apavlov)
Comment 3
Thursday, November 10, 2011 4:59:01 PM UTC
Created
attachment 114514
[details]
Patch
Pavel Feldman
Comment 4
Thursday, November 10, 2011 5:02:55 PM UTC
Comment on
attachment 114514
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=114514&action=review
> Source/WebCore/inspector/front-end/TextPrompt.js:383 > + var anchorElement = textRange.startContainer.ownerDocument.createElement("span");
document.createElement
Alexander Pavlov (apavlov)
Comment 5
Thursday, November 10, 2011 5:07:19 PM UTC
Committed
r99867
: <
http://trac.webkit.org/changeset/99867
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug