RESOLVED FIXED 72021
roll WebKit->Chromium DEPS to 109421 and change default Mac port 
https://bugs.webkit.org/show_bug.cgi?id=72021
Summary roll WebKit->Chromium DEPS to 109421 and change default Mac port
epoger
Reported 2011-11-10 06:21:23 PST
In http://src.chromium.org/viewvc/chrome?view=rev&revision=109421 , I changed the default 2d graphics backend in Chromium from CG to Skia. (More details are in http://crbug.com/101731 ('re-enable use_skia by default') ) This means that we also need to change the default port (for WebKit layout tests) accordingly. The attached patch rolls this Chromium change into WebKit and also changes the default Mac port for layout tests. Once we have seen Chromium r109421 land without trouble, and are reasonably certain it will "stick", we should apply this patch to the WebKit tree.
Attachments
Patch (7.09 KB, patch)
2011-11-10 06:25 PST, epoger 		eric: review-
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
epoger
Comment 1 2011-11-10 06:25:28 PST
Created attachment 114484 [details] Patch
WebKit Review Bot
Comment 2 2011-11-10 06:48:08 PST
Comment on attachment 114484 [details] Patch Attachment 114484 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10354374
Ojan Vafai
Comment 3 2011-11-10 08:38:08 PST
Comment on attachment 114484 [details] Patch I don't think you should wait for the downstream change to "stick". Someone else might roll the chromium DEPS and then suddenly a bunch of tests will start failing, right?
epoger
Comment 4 2011-11-10 10:40:46 PST
As discussed in http://crbug.com/101731 , we had to switch back to CG because of a performance regression. Holding off on this patch...
Eric Seidel (no email)
Comment 5 2011-12-21 15:10:25 PST
No need to sit in pending-commit until then. :)
Ryosuke Niwa
Comment 6 2011-12-21 15:14:41 PST
We've already switched over to Skia.
Note You need to log in before you can comment on or make changes to this bug.