Bug 72020 – Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Otherwise, I think there are no workers listed!

[Yury Semikhatsky]

Created attachment 114656 [details]
Patch

[Yury Semikhatsky]

Committed r99953: <http://trac.webkit.org/changeset/99953>

[Jonathan Backer]

Created attachment 114730 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Jonathan Backer]

Comment on attachment 114730 [details]
Patch

Ooops. Accidentally attached a patch to the wrong bug.

[Ojan Vafai]

This was rolled out in http://trac.webkit.org/changeset/100028.

[Yury Semikhatsky]

Created attachment 114896 [details]
Patch with failing assertion removed

Removed the ASSERT. Worker context termination notification may arrive after the page along with InspectorWorkerAgent has already been destroyed.

[Pavel Feldman]

Comment on attachment 114896 [details]
Patch with failing assertion removed

View in context: https://bugs.webkit.org/attachment.cgi?id=114896&action=review

> LayoutTests/platform/chromium/test_expectations.txt:3887
> +BUGWK72133 MAC : http/tests/inspector-enabled/dedicated-workers-list.html = PASS CRASH TIMEOUT

SKIP ?

[WebKit Review Bot]

Attachment 114896 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Last 3072 characters of output:
ctations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3855:  Path does not exist. svg/zoom/page/relative-sized-document-scrollbars.svg  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3857:  Path does not exist. storage/indexeddb/key-type-array.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3859:  Path does not exist. storage/indexeddb/factory-deletedatabase-interactions.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3861:  Path does not exist. fast/js/array-functions-non-arrays.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3862:  Path does not exist. fast/js/eval-cross-window.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3863:  Path does not exist. fast/js/regexp-caching.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3864:  Path does not exist. fast/js/toString-overrides.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3865:  Path does not exist. fast/js/toString-recursion.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3866:  Path does not exist. http/tests/security/xss-eval.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3868:  Path does not exist. fast/dom/javascript-url-exception-isolation.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3869:  Path does not exist. fast/borders/inline-mask-overlay-image-outset-vertical-rl.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3871:  Path does not exist. fast/dom/rtl-scroll-to-leftmost-and-resize.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3873:  Path does not exist. http/tests/inspector/resource-tree/appcache-iframe-manifests.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3875:  Path does not exist. accessibility/adjacent-continuations-cause-assertion-failure.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3877:  Path does not exist. inspector/debugger/script-formatter.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3880:  Path does not exist. fast/js/mozilla/strict/15.4.5.1.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3882:  Path does not exist. fast/canvas/canvas-transforms-fillRect-shadow.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3884:  Path does not exist. media/track/tracklist-is-reachable.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3886:  Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html  [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:3887:  Path does not exist. http/tests/inspector-enabled/dedicated-workers-list.html  [test/expectations] [2]
Total errors found: 2136 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

(In reply to comment #8)
> (From update of attachment 114896 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114896&action=review
> 
> > LayoutTests/platform/chromium/test_expectations.txt:3887
> > +BUGWK72133 MAC : http/tests/inspector-enabled/dedicated-workers-list.html = PASS CRASH TIMEOUT
> 
> SKIP ?

Done.

[Yury Semikhatsky]

Committed r100110: <http://trac.webkit.org/changeset/100110>

[Tony Gentilcore]

Reopening as this was rolled out in https://bugs.webkit.org/show_bug.cgi?id=72163

[Yury Semikhatsky]

(In reply to comment #12)
> Reopening as this was rolled out in https://bugs.webkit.org/show_bug.cgi?id=72163

The problem was fixed after rolling out and committed again, so there was no mistake in marking the bug as resolved.

[Tony Gentilcore]

(In reply to comment #13)
> (In reply to comment #12)
> > Reopening as this was rolled out in https://bugs.webkit.org/show_bug.cgi?id=72163
> 
> The problem was fixed after rolling out and committed again, so there was no mistake in marking the bug as resolved.

Oops, sorry. Thanks.