Bug 72011 – Move unit resolving for all resources to rendering/

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

Follow-up for bug 71780. Deploy SVGLengthContext in more places.

[Nikolas Zimmermann]

Created attachment 114491 [details]
Patch

[WebKit Review Bot]

Attachment 114491 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:593:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 114491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114491&action=review

r=me with some nits.

> Source/WebCore/rendering/svg/RenderSVGInlineText.h:56
> -    virtual FloatRect objectBoundingBox() const { return FloatRect(); }
> +    virtual FloatRect objectBoundingBox() const { return linesBoundingBox(); }

Awesome! :)

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:188
> -    filterData->builder = buildPrimitives(filterData->filter.get());
> +    filterData->builder = buildPrimitives(static_cast<SVGFilter*>(filterData->filter.get()));

This cast looks unnecessary.

> Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp:65
> +    // Eventually adjust focal points, as described below

Missing period at the end of this sentence.

> Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h:50
> +    void adjustFocalPointIfNeeded(float radius, const FloatPoint& centerPoint, FloatPoint&) const;

I think we should name the last argument here (focalPoint.)

[Nikolas Zimmermann]

Fixed Andreas issues. Landed in r99854. Waiting for bots to cycle...

[WebKit Review Bot]

Comment on attachment 114491 [details]
Patch

Attachment 114491 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10395340

New failing tests:
svg/filters/filter-on-filter-for-text.svg
svg/filters/filter-on-tspan.svg
svg/custom/text-filter.svg
svg/filters/feColorMatrix-values.svg

[Nikolas Zimmermann]

Landed qt rebaselines in r99858.

[Nikolas Zimmermann]

(In reply to comment #6)
> Landed qt rebaselines in r99858.
Landed gtk/win rebaselines in r99882.

[Nikolas Zimmermann]

Ojan rebaselined Chromium in r99880 - we're done. Closing bug.