Bug 72008 - A test for css parser: \r\n.
Summary: A test for css parser: \r\n.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 69083
  Show dependency tree / graph
 
Reported: 2011-11-10 01:55 PST by Szilard Ledan
Modified: 2011-11-30 18:10 PST (History)
3 users (show)

See Also:

Attachments
newline with unicode - JavaScript test (4.46 KB, patch)
2011-11-11 00:36 PST, Szilard Ledan 		no flags Details | Formatted Diff | Diff
updated test (4.46 KB, patch)
2011-11-25 00:35 PST, Szilard Ledan 		no flags Details | Formatted Diff | Diff
updated patch v2. (3.00 KB, patch)
2011-11-25 07:54 PST, Szilard Ledan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szilard Ledan 2011-11-10 01:55:11 PST 
The css number types (px, pt, cm, ...) can be specified escape sequences (px = \70\78,...).
Comment 1 Szilard Ledan 2011-11-11 00:36:24 PST 
Created attachment 114639 [details]
newline with unicode - JavaScript test
Comment 2 Zoltan Herczeg 2011-11-24 05:56:47 PST 
Hey Szilard, the name of the bug should be \r\n. And it seems to me that something is not working since you attached a layout dump not a text dump.
Comment 3 Szilard Ledan 2011-11-25 00:35:15 PST 
Created attachment 116578 [details]
updated test
Comment 4 Szilard Ledan 2011-11-25 07:54:23 PST 
Created attachment 116619 [details]
updated patch v2.
Comment 5 Darin Adler 2011-11-30 10:48:36 PST 
Comment on attachment 116619 [details]
updated patch v2.

This test is OK, but not great. The output is confusing because both the rules and expected result seem to match. I’d love to see a clearer version.
Comment 6 Darin Adler 2011-11-30 10:49:21 PST 
Comment on attachment 116619 [details]
updated patch v2.

I also think this is too little for a single test to cover. We should come up with a way to cover many different CSS parser test cases with a single test instead of having a test that focuses on only this one issue.
Comment 7 WebKit Review Bot 2011-11-30 18:10:52 PST 
Comment on attachment 116619 [details]
updated patch v2.

Clearing flags on attachment: 116619

Committed r101581: <http://trac.webkit.org/changeset/101581>
Comment 8 WebKit Review Bot 2011-11-30 18:10:56 PST 
All reviewed patches have been landed.  Closing bug.