Bug 72007 – A test for css parser number types problem.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Szilard Ledan]

The css number types (px, pt, cm, ...) can be specified escape sequences (px = \70\78,...).

[Szilard Ledan]

Created attachment 114637 [details]
A test for CSS lexer rules, where the dimensions define like utf-8 code.

[Zoltan Herczeg]

Please set r? to the patch.

[Szilard Ledan]

(In reply to comment #2)
> Please set r? to the patch.

Thanks!

[Zoltan Herczeg]

Comment on attachment 114637 [details]
A test for CSS lexer rules, where the dimensions define like utf-8 code.

View in context: https://bugs.webkit.org/attachment.cgi?id=114637&action=review

> LayoutTests/fast/css/parsing-css-number-types.html:13
> +#a { font-size: 16px; }
> +#b { font-size: 16\70\78; }
> +#c { font-size: 16\70x; }
> +#d { font-size: 16p\78; }
> +#e { font-size: 1em; }
> +#f { font-size: 1\65m; }
> +#g { font-size: 1\65\6D; }
> +#h { font-size: 1\65\6d; }
> +#i { font-size: 12pt }

Please add some uppercase / lowercase test here.
I.e: 12pT same as 12\70\54

Would be a good idea to add more number types (S, KhZ, gRaD). You can find them in tokenizer.flex grouped in one block (lines starting with {num}).

[Szilard Ledan]

Created attachment 116209 [details]
Updated patch

[Zoltan Herczeg]

Darin, what do you think of this patch?

[WebKit Review Bot]

Comment on attachment 116209 [details]
Updated patch

Clearing flags on attachment: 116209

Committed r102350: <http://trac.webkit.org/changeset/102350>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.