Bug 71969 - De-virtualize JSGlobalObject::allowsAccessFrom
Summary: De-virtualize JSGlobalObject::allowsAccessFrom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 16:40 PST by Mark Hahnenberg
Modified: 2011-11-11 11:35 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2011-11-09 17:08 PST, Mark Hahnenberg 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-11-09 16:40:29 PST 
There's only one call site of this function in WebScriptObject which we can safely cast to JSDOMWindowBase and call that version of the function, eliminating the need for this function to be virtual (or present in JSGlobalObject at all).
Comment 1 Mark Hahnenberg 2011-11-09 17:08:52 PST 
Created attachment 114399 [details]
Patch
Comment 2 Mark Hahnenberg 2011-11-11 11:35:40 PST 
Committed r99993: <http://trac.webkit.org/changeset/99993>