Bug 71940 – [GTK] Make the ENABLE(FEATURE) macro work in DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alexandre Mazari]

[GTK] Make the ENABLE(FEATURE) macro work in DRT

[Alexandre Mazari]

Created attachment 114325 [details]
Patch

[Philippe Normand]

Comment on attachment 114325 [details]
Patch

Missing ChangeLog!

[Alexandre Mazari]

Created attachment 114463 [details]
Patch

[Alexandre Mazari]

(In reply to comment #3)
> Created an attachment (id=114463) [details]
> Patch

Updated:
- add ChangeLog entry

[Philippe Normand]

Comment on attachment 114463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114463&action=review

> Tools/ChangeLog:1
> [phone]  Alexandre Mazari  <[e-mail]>

This is not consistent with your other patches. Any reason to no use your igalia address?

> Tools/ChangeLog:9
> +        * GNUmakefile.am:
> +

Even though this is a pretty trivial and small change it would be good to explain it. This is what the ChangeLog entry is about.

[Alexandre Mazari]

Created attachment 114482 [details]
Patch

[Alexandre Mazari]

Hi Philippe,

Thanks for your review.

(In reply to comment #5)
> (From update of attachment 114463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114463&action=review
> 
> > Tools/ChangeLog:1
> > [phone]  Alexandre Mazari  <[e-mail]>
> 
> This is not consistent with your other patches. Any reason to no use your igalia address?

Fixed. Don't even know where the changelog generator got this email from :)

> 
> > Tools/ChangeLog:9
> > +        * GNUmakefile.am:
> > +
> 
> Even though this is a pretty trivial and small change it would be good to explain it. This is what the ChangeLog entry is about.

Done.

[WebKit Review Bot]

Comment on attachment 114482 [details]
Patch

Clearing flags on attachment: 114482

Committed r99852: <http://trac.webkit.org/changeset/99852>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.