Bug 71940 - [GTK] Make the ENABLE(FEATURE) macro work in DRT
Summary: [GTK] Make the ENABLE(FEATURE) macro work in DRT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66477
  Show dependency treegraph
 
Reported: 2011-11-09 11:24 PST by Alexandre Mazari
Modified: 2011-11-10 07:24 PST (History)
1 user (show)

See Also:


Attachments
Patch (548 bytes, patch)
2011-11-09 11:24 PST, Alexandre Mazari
no flags Details | Formatted Diff | Diff
Patch (1.06 KB, patch)
2011-11-10 02:49 PST, Alexandre Mazari
no flags Details | Formatted Diff | Diff
Patch (1.17 KB, patch)
2011-11-10 06:12 PST, Alexandre Mazari
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Mazari 2011-11-09 11:24:05 PST
[GTK] Make the ENABLE(FEATURE) macro work in DRT
Comment 1 Alexandre Mazari 2011-11-09 11:24:28 PST
Created attachment 114325 [details]
Patch
Comment 2 Philippe Normand 2011-11-09 11:32:18 PST
Comment on attachment 114325 [details]
Patch

Missing ChangeLog!
Comment 3 Alexandre Mazari 2011-11-10 02:49:42 PST
Created attachment 114463 [details]
Patch
Comment 4 Alexandre Mazari 2011-11-10 02:56:34 PST
(In reply to comment #3)
> Created an attachment (id=114463) [details]
> Patch

Updated:
- add ChangeLog entry
Comment 5 Philippe Normand 2011-11-10 05:20:18 PST
Comment on attachment 114463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114463&action=review

> Tools/ChangeLog:1
> +2011-11-09  Alexandre Mazari  <alexandre.mazari@gmail.com>

This is not consistent with your other patches. Any reason to no use your igalia address?

> Tools/ChangeLog:9
> +        * GNUmakefile.am:
> +

Even though this is a pretty trivial and small change it would be good to explain it. This is what the ChangeLog entry is about.
Comment 6 Alexandre Mazari 2011-11-10 06:12:36 PST
Created attachment 114482 [details]
Patch
Comment 7 Alexandre Mazari 2011-11-10 06:15:02 PST
Hi Philippe,

Thanks for your review.

(In reply to comment #5)
> (From update of attachment 114463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114463&action=review
> 
> > Tools/ChangeLog:1
> > +2011-11-09  Alexandre Mazari  <alexandre.mazari@gmail.com>
> 
> This is not consistent with your other patches. Any reason to no use your igalia address?

Fixed. Don't even know where the changelog generator got this email from :)

> 
> > Tools/ChangeLog:9
> > +        * GNUmakefile.am:
> > +
> 
> Even though this is a pretty trivial and small change it would be good to explain it. This is what the ChangeLog entry is about.

Done.
Comment 8 WebKit Review Bot 2011-11-10 07:24:12 PST
Comment on attachment 114482 [details]
Patch

Clearing flags on attachment: 114482

Committed r99852: <http://trac.webkit.org/changeset/99852>
Comment 9 WebKit Review Bot 2011-11-10 07:24:16 PST
All reviewed patches have been landed.  Closing bug.