Bug 71922 - Web Inspector: [refactoring] get rid of JavaScriptSourceFrameDelegate
Summary: Web Inspector: [refactoring] get rid of JavaScriptSourceFrameDelegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 09:00 PST by Andrey Kosyakov
Modified: 2011-11-10 02:09 PST (History)
10 users (show)

See Also:


Attachments
Patch (15.68 KB, patch)
2011-11-09 09:03 PST, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
Patch (15.64 KB, patch)
2011-11-09 09:22 PST, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-11-09 09:00:25 PST
... use ScriptsPanel directly from JavaScriptSourceFrame.
Comment 1 Andrey Kosyakov 2011-11-09 09:03:33 PST
Created attachment 114297 [details]
Patch
Comment 2 Pavel Feldman 2011-11-09 09:15:15 PST
Comment on attachment 114297 [details]
Patch

Please fix the test LayoutTests/inspector/debugger/debugger-breakpoints-not-activated-on-reload.html.
Comment 3 Andrey Kosyakov 2011-11-09 09:22:49 PST
Created attachment 114300 [details]
Patch
Comment 4 Pavel Feldman 2011-11-10 01:30:25 PST
Comment on attachment 114300 [details]
Patch

Please convert that getter to a function.
Comment 5 Andrey Kosyakov 2011-11-10 02:09:59 PST
Committed r99829: <http://trac.webkit.org/changeset/99829>