Bug 71917 - StyleSheet: Devirtualize is{CSS,XSL}StyleSheet().
Summary: StyleSheet: Devirtualize is{CSS,XSL}StyleSheet().
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 07:52 PST by Andreas Kling
Modified: 2011-11-09 08:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.48 KB, patch)
2011-11-09 08:01 PST, Andreas Kling 		kling: review-
Details | Formatted Diff | Diff
Patch v2 (7.46 KB, patch)
2011-11-09 08:10 PST, Andreas Kling 		kling: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-09 07:52:58 PST 
Let's put the subclass type in a bit instead. This will also let us assert that XSLStyleSheets aren't created with CSSRule parents.
Comment 1 Andreas Kling 2011-11-09 08:01:07 PST 
Created attachment 114281 [details]
Patch
Comment 2 Andreas Kling 2011-11-09 08:02:53 PST 
Comment on attachment 114281 [details]
Patch

Woops, didn't remove the virtuals from the subclasses!
Comment 3 Andreas Kling 2011-11-09 08:10:26 PST 
Created attachment 114283 [details]
Patch v2
Comment 4 Antti Koivisto 2011-11-09 08:17:03 PST 
Comment on attachment 114281 [details]
Patch

I don't think we should do this as there don't seem to be compelling performance or memory arguments for complete devirtualization here.