Bug 71912 - Fixing build on MacOSX SL after 71838
Summary: Fixing build on MacOSX SL after 71838
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 07:18 PST by Alexandru Chiculita
Modified: 2011-11-09 10:41 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2011-11-09 07:23 PST, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2011-11-09 07:18:15 PST
I have the following error when building on MacOSX SL:

Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: In constructor ‘WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea(WebKit::WebPage*, const WebKit::WebPageCreationParameters&)’:
Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:54: error: setting a C++ non-POD object value is not implemented - assign the value to a temporary and use the temporary.
cc1objplus: warnings being treated as errors
Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:54: warning: left-hand operand of comma has no effect
Comment 1 Alexandru Chiculita 2011-11-09 07:23:34 PST
Created attachment 114272 [details]
Patch
Comment 2 Anders Carlsson 2011-11-09 09:54:31 PST
Comment on attachment 114272 [details]
Patch

I'd prefer static_cast over a C-style cast, but r=me anyway.
Comment 3 WebKit Review Bot 2011-11-09 10:41:30 PST
Comment on attachment 114272 [details]
Patch

Clearing flags on attachment: 114272

Committed r99735: <http://trac.webkit.org/changeset/99735>
Comment 4 WebKit Review Bot 2011-11-09 10:41:34 PST
All reviewed patches have been landed.  Closing bug.