RESOLVED FIXED 71891
[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view. 
https://bugs.webkit.org/show_bug.cgi?id=71891
Summary [EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ew...
Raphael Kubo da Costa (:rakuco)
Reported 2011-11-09 05:06:44 PST
[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
Attachments
Patch (2.43 KB, patch)
2011-11-09 05:07 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-11-09 05:07:56 PST
Created attachment 114253 [details] Patch
Antonio Gomes
Comment 2 2011-11-09 06:47:50 PST
Comment on attachment 114253 [details] Patch raw "new" calls? mmmm.... :)
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-11-09 07:11:01 PST
(In reply to comment #2) > (From update of attachment 114253 [details]) > raw "new" calls? mmmm.... :) That's the common approach. Page::PageClient is passed to Page's constructor, which then adoptPtr's these pointers. Could you cq+ the patch as well?
WebKit Review Bot
Comment 4 2011-11-09 09:33:04 PST
Comment on attachment 114253 [details] Patch Clearing flags on attachment: 114253 Committed r99728: <http://trac.webkit.org/changeset/99728>
WebKit Review Bot
Comment 5 2011-11-09 09:33:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.