Bug 71890 – [GTK][DRT] window internals object is not reset after each test

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

If a test for instance modifies the Pagination setting, the next tests not explicitely resetting that setting will fail or simply appear flaky.

Proper fix would be to call WebCoreTestSupport::resetInternalsObject() when needed, like mac and qt do...

[Philippe Normand]

Created attachment 114252 [details]
proposed patch

[Xan Lopez]

Comment on attachment 114252 [details]
proposed patch

Dunno if it makes sense to share this with Qt or not, but looks good to me. Good catch.

[WebKit Review Bot]

Attachment 114252 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:70:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Committed r99691: <http://trac.webkit.org/changeset/99691>

[Csaba Osztrogonác]

(In reply to comment #4)
> Committed r99691: <http://trac.webkit.org/changeset/99691>

It broke the GTK build:

./.libs/libwebkitgtk-3.0.so: undefined reference to `WebCoreTestSupport::resetInternalsObject(OpaqueJSContext const*)'

[Philippe Normand]

(In reply to comment #5)
> (In reply to comment #4)
> > Committed r99691: <http://trac.webkit.org/changeset/99691>
> 
> It broke the GTK build:
> 
> ./.libs/libwebkitgtk-3.0.so: undefined reference to `WebCoreTestSupport::resetInternalsObject(OpaqueJSContext const*)'

A clean build is in progress to confirm that.
It passed on the Debug bots though...

[Philippe Normand]

Turns out this broke non GNU-Gold builds. Sorry!
Working on a follow-up patch

[Philippe Normand]

Created attachment 114334 [details]
updated patch

[Martin Robinson]

Comment on attachment 114334 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114334&action=review

Thank you!

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:727
> +    JSGlobalContextRef globalContext = webkit_web_frame_get_global_context(mainFrame);
> +    WebCoreTestSupport::resetInternalsObject(globalContext);

Can probably just be one line.

[Philippe Normand]

Committed r99748: <http://trac.webkit.org/changeset/99748>