Bug 71887 - [Qt] Enable geolocation by default
Summary: [Qt] Enable geolocation by default
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 03:57 PST by Kenneth Rohde Christiansen
Modified: 2014-02-03 03:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2011-11-09 03:57 PST, Kenneth Rohde Christiansen 		hausmann: review-
hausmann: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2011-11-09 03:57:19 PST 
SSIA
Comment 1 Kenneth Rohde Christiansen 2011-11-09 03:57:50 PST 
Created attachment 114240 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-09 04:01:58 PST 
Attachment 114240 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/build-we..." exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Hausmann 2011-11-09 11:56:02 PST 
Comment on attachment 114240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114240&action=review

I believe enabling this by default is going to break the build for setups where the necessary dependencies are not installed, because the build system does not automatically disable the feature again. The existing logic only covers enabling it, if the corresponding qt module is found. It doesn't cover disabling it if it's not found.

>> Tools/ChangeLog:1

> 
> ChangeLog entry has no bug number  [changelog/bugnumber] [5]

Style bot is correct here: There _is_ a bug, but it's not mentioned in ChangeLog :)
Comment 4 Jocelyn Turcotte 2014-02-03 03:19:12 PST 
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.