Bug 71880 - [Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
Summary: [Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL: http://test-results.appspot.com/dashb...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-09 01:40 PST by Yuta Kitamura
Modified: 2011-11-09 14:17 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.77 KB, patch)
2011-11-09 12:28 PST, Ojan Vafai
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-11-09 01:40:31 PST
The following layout test is timing out on all platforms of Chromium.

fast/forms/select-clientheight-large-size.html

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fforms%2Fselect-clientheight-large-size.html

This test times out without printing any console message.

Probable cause:

This is a new test from r99653. Antaryami, do you have any idea why the test times out?
Comment 1 Yuta Kitamura 2011-11-09 01:46:50 PST
This test is timing out only on Debug bots. Release bots seem fine.
Comment 2 Antaryami Pandia 2011-11-09 02:42:55 PST
One probable reason might be that we are adding large number of option elements to the select box here (10000 to be precise).

I don't have chromium build.So can somebody with chromium build help me with this(by reducing the value), while I am setting up chromium build.
Comment 3 Ojan Vafai 2011-11-09 11:14:57 PST
I can fix this. Is there a reason we need to test 10000 options? Looking at r99653, testing 100 options seems like it would cover all the same edge cases.
Comment 4 Ojan Vafai 2011-11-09 12:28:52 PST
Created attachment 114342 [details]
Patch
Comment 5 Tony Chang 2011-11-09 12:36:06 PST
Comment on attachment 114342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114342&action=review

> LayoutTests/fast/forms/select-clientheight-large-size.html:23
> +        for (var i = 0; i<= numOptions; i++)

Nit: missing space between i and <=
Comment 6 Ojan Vafai 2011-11-09 14:17:03 PST
Committed r99759: <http://trac.webkit.org/changeset/99759>