Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
Created attachment 114208 [details] Patch
Comment on attachment 114208 [details] Patch Itβs wrong to assume that emptyValueIsZero also means that you can default construct.
Created attachment 114307 [details] Patch
Attachment 114307 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/Alignment.h:40: __attribute__ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/Alignment.h:46: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:47: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:48: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:49: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:50: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:51: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:52: More than one command on the same line [whitespace/newline] [4] Total errors found: 8 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 114307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114307&action=review > Source/JavaScriptCore/wtf/HashTable.h:642 > + // The memset to 0 looks like a slow operation is optimized by the compilers. Looks like a missing "but" here.
Committed r99733: <http://trac.webkit.org/changeset/99733>